🐛 Add ability to abort servicing by clearing HFS and HFC spec #2688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated-By: Claude Code Sonnet 4 Signed-off-by: Jacob Anders <[email protected]> (cherry picked from commit c40d0ad) (cherry picked from commit 4a2c782)
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
size/L
Member
Author
|
/hold |
metal3-io-bot
added
the
do-not-merge/hold
Signed-off-by: Jacob Anders <[email protected]>
rhjanders
force-pushed
the
servicing-abort-upstream
branch
from
b7253d7 to
48692d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Currently, if a servicing operation fails, the user has no simple way of recovering from the failure and returning the BMH back to a good state. There is also no simple way to interrupt a running servicing operation either. This change resolves this issue by exposing Ironic's abort verb in BMO so that it can be used to recover from failed servicing operations.
When the BMH is in service failed or service wait state and the user deletes HFS.spec and HFC.spec, BMO will issue abort request to Ironic, aborting servicing and returning the BMH to the original state.
Generated-By: Claude Code Sonnet 4
(cherry picked from commit c40d0ad) (cherry picked from commit 4a2c782)