Skip to content

Commit aa3b3dc

Browse files
zigzagdevGromNaN
authored andcommitted
fix: review-fix
1 parent a84d28e commit aa3b3dc

File tree

1 file changed

+8
-18
lines changed

1 file changed

+8
-18
lines changed

tests/ModelTest.php

Lines changed: 8 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,7 @@ class ModelTest extends TestCase
5252
protected function setUp(): void
5353
{
5454
parent::setUp();
55+
5556
Carbon::setTestNow();
5657
}
5758

@@ -89,27 +90,22 @@ public function testQualifyColumn(): void
8990
$this->assertEquals('users.name', $sqlUser->qualifyColumn('name'));
9091
}
9192

92-
private function makeUser(array $overrides = []): User
93+
private function makeUser(): User
9394
{
94-
$defaults = [
95-
'name' => 'John Doe',
96-
'title' => 'admin',
97-
'age' => 35,
98-
];
99-
10095
$user = new User();
101-
foreach (array_merge($defaults, $overrides) as $key => $value) {
102-
$user->$key = $value;
103-
}
96+
$user->name = 'John Doe';
97+
$user->title = 'admin';
98+
$user->age = 35;
99+
100+
$user->save();
101+
104102
return $user;
105103
}
106104

107105
public function testInsert(): void
108106
{
109107
$user = $this->makeUser();
110108

111-
$user->save();
112-
113109
$this->assertTrue($user->exists);
114110
$this->assertEquals(1, User::count());
115111

@@ -149,7 +145,6 @@ public function testInsertNonIncrementable(): void
149145
public function testUpdate(): void
150146
{
151147
$user = $this->makeUser();
152-
$user->save();
153148

154149
$raw = $user->getAttributes();
155150
$this->assertInstanceOf(ObjectID::class, $raw['id']);
@@ -280,7 +275,6 @@ public function testManualIntId(): void
280275
public function testDelete(): void
281276
{
282277
$user = $this->makeUser();
283-
$user->save();
284278

285279
$this->assertTrue($user->exists);
286280
$this->assertEquals(1, User::count());
@@ -293,7 +287,6 @@ public function testDelete(): void
293287
public function testAll(): void
294288
{
295289
$user = $this->makeUser();
296-
$user->save();
297290

298291
$user = new User();
299292
$user->name = 'Jane Doe';
@@ -311,7 +304,6 @@ public function testAll(): void
311304
public function testFind(): void
312305
{
313306
$user = $this->makeUser();
314-
$user->save();
315307

316308
$check = User::find($user->id);
317309
$this->assertInstanceOf(User::class, $check);
@@ -391,7 +383,6 @@ public function testCreate(): void
391383
public function testDestroy(): void
392384
{
393385
$user = $this->makeUser();
394-
$user->save();
395386

396387
User::destroy((string) $user->id);
397388

@@ -401,7 +392,6 @@ public function testDestroy(): void
401392
public function testTouch(): void
402393
{
403394
$user = $this->makeUser();
404-
$user->save();
405395

406396
$old = $user->updated_at;
407397
sleep(1);

0 commit comments

Comments
 (0)