Skip to content

Conversation

@kwindau
Copy link
Contributor

@kwindau kwindau commented Aug 27, 2025

Description

This PR deprecates the 2 versions of tables that have been replaced with newer, better versions that should now be used in their place.

  • moz-fx-data-shared-prod.mozilla_org_derived.ga_sessions_v2 (users should now use moz-fx-data-shared-prod.mozilla_org_derived.ga_sessions_v3)
  • moz-fx-data-shared-prod.firefoxdotcom_derived.ga_sessions_v1 (users should now use moz-fx-data-shared-prod.firefoxdotcom_derived.ga_sessions_v2)

Related Tickets & Documents

Reviewer, please follow this checklist

@kwindau kwindau marked this pull request as ready for review August 27, 2025 12:55
@kwindau kwindau marked this pull request as draft August 27, 2025 12:57
@dataops-ci-bot

This comment has been minimized.

@dataops-ci-bot
Copy link

Integration report for "Merge branch 'main' into deprecate-old-ga-sessions"

sql.diff

Click to expand!
diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/firefoxdotcom_derived/ga_sessions_v1/metadata.yaml /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/firefoxdotcom_derived/ga_sessions_v1/metadata.yaml
--- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/firefoxdotcom_derived/ga_sessions_v1/metadata.yaml	2025-12-05 20:21:02.000000000 +0000
+++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/firefoxdotcom_derived/ga_sessions_v1/metadata.yaml	2025-12-05 20:20:40.000000000 +0000
@@ -27,21 +27,13 @@
     fields:
     - ga_client_id
     - country
-workgroup_access:
-- role: roles/bigquery.dataViewer
-  members:
-  - workgroup:dataops-managed/external-census
-  - workgroup:google-managed/external-ads-datafusion
-  - workgroup:google-managed/external-ads-dataproc
-  - workgroup:mozilla-confidential
-- role: roles/bigquery.metadataViewer
-  members:
-  - workgroup:google-managed/external-ads-dataproc
+workgroup_access: []
 references:
   script.sql:
   - moz-fx-data-marketing-prod.analytics_489412379.events_*
   - moz-fx-data-marketing-prod.analytics_489412379.events_2*
   - moz-fx-data-shared-prod.firefoxdotcom_derived.ga_sessions_v1
+deprecated: true
 monitoring:
   enabled: true
   collection: null
diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/mozilla_org_derived/ga_sessions_v2/metadata.yaml /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/mozilla_org_derived/ga_sessions_v2/metadata.yaml
--- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/mozilla_org_derived/ga_sessions_v2/metadata.yaml	2025-12-05 20:21:02.000000000 +0000
+++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/mozilla_org_derived/ga_sessions_v2/metadata.yaml	2025-12-05 20:20:40.000000000 +0000
@@ -26,17 +26,7 @@
     fields:
     - ga_client_id
     - country
-workgroup_access:
-- role: roles/bigquery.dataViewer
-  members:
-  - workgroup:dataops-managed/external-census
-  - workgroup:google-managed/external-ads-datafusion
-  - workgroup:google-managed/external-ads-dataproc
-  - workgroup:mozilla-confidential
-- role: roles/bigquery.metadataViewer
-  members:
-  - workgroup:dataops-managed/external-fides
-  - workgroup:google-managed/external-ads-dataproc
+workgroup_access: []
 references:
   checks.sql:
   - ..
@@ -44,5 +34,6 @@
   - moz-fx-data-marketing-prod.analytics_313696158.events_*
   - moz-fx-data-marketing-prod.analytics_313696158.events_2*
   - moz-fx-data-shared-prod.mozilla_org_derived.ga_sessions_v2
+deprecated: true
 require_column_descriptions: false
 level: null

Link to full diff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants