Skip to content

Conversation

@k-yle
Copy link
Member

@k-yle k-yle commented Nov 17, 2025

Closes #11536

I didn't add this feature at the time, beacuse I wasn't sure how we should handle features with multiple wikidata tags (for example, this one which has both brand & operator).

Currently it just picks one of the *:wikidata tags for the query. Maybe it would be better to construct a more complex query for this case?

@k-yle k-yle marked this pull request as draft November 17, 2025 12:15
@k-yle
Copy link
Member Author

k-yle commented Nov 20, 2025

@UKChris-osm do you have an opinion about how the overpass query should be constructed for features with both brand and operator?

should the green styling require both brand[:*] and operator[:*] to be set correctly?

@UKChris-osm
Copy link
Collaborator

It would be handy if the green styling could be retained when an exact match is found, with perhaps a different colour for one that matches just the brand, but not operator (and vice versa) but for entries with both it can be tricky, and so in that respect it might be safter to removed the styling and go for a more basic match which we used to do, which was a name / type match.

@k-yle k-yle force-pushed the kh/overpass-tree-star branch from c96188e to fe7ded2 Compare November 25, 2025 08:43
@k-yle k-yle marked this pull request as ready for review November 25, 2025 08:44
@k-yle
Copy link
Member Author

k-yle commented Nov 25, 2025

okay, updated. Here's an example of the query that's generated for presets with both brand[:*] and operator[:*]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix overpass links on nsi.guide when tree = *

2 participants