-
Notifications
You must be signed in to change notification settings - Fork 3.2k
ci: remove prepack and prepublishonly scripts, fix build:debug issues #14832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
📦 esbuild Bundle Analysis for payloadThis analysis was generated by esbuild-bundle-analyzer. 🤖 |
AlessioGr
commented
Dec 6, 2025
| @@ -0,0 +1,24 @@ | |||
| import { mkdirSync, writeFileSync } from 'fs' | |||
Member
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is run for build:debug - since we don't have a css bundle there
denolfe
approved these changes
Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
prepackandprepublishonlyscripts, which have become unnecessary and counterproductive.PR #14820 introduced a new
pnpm build:debugcommand. However, when running our pre-release publish workflow, each package is currently built twice: once viapnpm build:debug(as intended) and again via the hard-codedprepublishonlyscript. Because prepublishonly always runs a clean, non-debug build, it both nullifies the debug output and adds significant overhead by rebuilding everything.All of our release and pack-to-destination scripts already perform a full build ahead of time, so these additional prepublish hooks provide no benefit and actively interfere with the intended debug workflow. This PR removes the redundant scripts to ensure debug builds work as expected and to speed up the release process.
Additionally, this PR fixes some issues with the build:debug script:
@payloadcms/nextpackage