Skip to content

Race Condition - Synchronise event: Force push on approved PR leads to merge rather than retests #1219

@vipulgupta2048

Description

@vipulgupta2048

PR: balena-io/docs#3084

Scenario:

  1. A pushed a test commit on an auto-merge PR
  2. A approved the PR. PR doesn't get merged since A has committed on it.
  3. B removed A's test commit and force push.
  4. Instead of tests running again, a race condition happens, all conditions get met and the PR merges immediately.

Problem

My force push created a synchronized event that didn't get tested again; instead, the PR was merged.

Downloaded Logs

  1. Synchronize event didn't finish due to race condition:
    logs_29694248838.zip | https://github.com/balena-io/docs/actions/runs/11366382108/job/31616690787

  2. Closed event right after it as the PR merged:
    logs_29694250989.zip https://github.com/balena-io/docs/actions/runs/11363520188

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions