[psutil] add overloads for cpu_affinity #15112
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
donbarbos
reviewed
Dec 7, 2025
Comment on lines
+205
to
206
| @overload | ||
| def cpu_affinity(self, cpus: list[int] | None = None) -> list[int] | None: ... |
Contributor
There was a problem hiding this comment.
I think we can get rid of the 3rd overload. The first two cover both cases
Suggested change
| @overload | |
| def cpu_affinity(self, cpus: list[int] | None = None) -> list[int] | None: ... |
Contributor
Author
There was a problem hiding this comment.
Probably true for the vast majority of cases, yes; but there are valid reasons to keep the combination, for example if someone is proxying the Process object calls. I defer to you; if you want I can add the removal as a separate commit here and see if there is any impact in mypy_primer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.