Fix default :excluded_paths regex in ModuleDependencies check to exclude first-level test files #1216
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ModuleDependenciescheck was incorrectly triggered on code under thetestfolder with default settings.
Example:
mix credo test/supex_test.exs ... [F] → Module has too many dependencies: 11 (max is 10) test/supex_test.exs:1:11 #(SupexTest)Cause:
Path.dirname/1does not return a trailing/, so first-level test files(e.g.
test/foo_test.exs) were not excluded(
lib/credo/check/refactor/module_dependencies.ex:65).Fix: Adjusted the default
:excluded_pathsregex to also match first-level testfiles.
Added a test to confirm files in
test/are excluded.PS: Thanks for this awesome project :)