refactor!: rename blacklist to blocklist

[conlank]

Description

Updated all occurrences of blacklist to blocklist. I did not use AI to perform this change.

To-Dos

• Disclosed any use of AI (see our policy)
• Successful build pnpm build
• Translation keys pnpm i18n:extract
• Database migration (if required)

Issues Fixed or Closed

• Fixes use of blacklist

[TheCatLady]

The affected language strings were simply renamed in translations. However, those strings should be re-translated in Weblate.

The existing translations also use "blacklist" terminology this PR is addressing (e.g., "lista negra" in pt-PT, "黑名单" in zh-Hans).

Please revert the changes to files in the src/i8n/locale directory and regenerate the translation keys using pnpm i18n:extract.

[TheCatLady]

@conlank I see you reverted the changes to globalMessages.ts as well. Are those strings used anywhere / did you make sure this still builds?

[conlank]

@conlank I see you reverted the changes to globalMessages.ts as well. Are those strings used anywhere / did you make sure this still builds?

Thank you for pointing out my mistake, I was working on this late and forgot to run the build / extract commands before committing.

[0xSysR3ll]

We shouldn't modify existing migration files, as that would break existing installations - those migrations won't run again. Instead, we should add a new migration to handle the rename properly.
Would you be able to do that ? If not, we'll do it afterwards.

[fallenbagel]

Here too

[fallenbagel]

This file migration names need to be restored

And the migration part

[0xSysR3ll]

We shouldn't modify existing migration files, as that would break existing installations - those migrations won't run again. Instead, we should add a new migration to handle the rename properly.

Would you be able to do that ? If not, we'll do it afterwards.

@conlank I didn't get your answer on this. Do you think you can make the migration file ?

[sct]

I understand the sentiment in this change but we can't simply make breaking api changes without versioning them. This will break anyone using our API via third party apps.

[fallenbagel]

I understand the sentiment in this change but we can't simply make breaking api changes without versioning them. This will break anyone using our API via third party apps.

I agree. Therefore, I just pushed a commit to add a deprecation notice to old routes

[Copilot]

Pull request overview

This pull request performs a comprehensive refactoring to rename "blacklist" terminology to "blocklist" throughout the codebase. The change affects frontend components, backend routes, database entities, permissions, job schedulers, API documentation, and user-facing documentation.

Key Changes:

• Renamed all React components, hooks, and TypeScript types from "Blacklist" to "Blocklist"
• Updated i18n translation keys and messages across all languages
• Renamed backend routes from /blacklist to /blocklist with deprecation middleware for backward compatibility
• Renamed entity classes, permissions, and settings from "Blacklist" to "Blocklist"
• Updated API documentation in seerr-api.yml to reflect new endpoint names
• Updated user documentation to use "blocklist" terminology

Critical Issues Identified:

Unfortunately, this PR has critical bugs that will cause runtime failures:

1. Database table name mismatch: The Blocklist entity class doesn't specify a table name in the @Entity() decorator, causing TypeORM to look for a "blocklist" table that doesn't exist. The actual database table is still named "blacklist".

2. Database column name mismatch: The blocklistedTags property doesn't specify the column name in the @Column() decorator, causing TypeORM to look for a "blocklistedTags" column. The actual database column is "blacklistedTags".

3. Missing database migrations: The PR description indicates that database migration is not complete (the checkbox is unchecked), which aligns with the issues found. Either migrations need to be created to rename the table and column, OR the entity needs to explicitly specify the legacy names.

Positive Aspects:

• Comprehensive and consistent refactoring across the entire codebase
• Well-implemented deprecation middleware following RFC 8594 standards
• Proper backward compatibility for API endpoints
• Clean translation key updates

Reviewed changes

Copilot reviewed 49 out of 49 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
src/pages/blocklist/index.tsx	New page component for blocklist (replaces blacklist page)
src/pages/blacklist/index.tsx	Removed old blacklist page
src/components/Blocklist/index.tsx	Renamed main blocklist component with updated API calls
src/components/BlocklistModal/index.tsx	Renamed modal component for blocklist operations
src/components/BlocklistBlock/index.tsx	Renamed block component for displaying blocklist items
src/components/BlocklistedTagsSelector/index.tsx	Renamed tags selector component
src/components/BlocklistedTagsBadge/index.tsx	Renamed badge component
src/i18n/locale/en.json	Updated all translation keys from blacklist to blocklist
src/i18n/globalMessages.ts	Updated message definitions
server/entity/Blocklist.ts	CRITICAL: Renamed entity but missing table/column name mappings
server/routes/blocklist.ts	Renamed routes with updated queries
server/routes/index.ts	Added deprecation middleware for old /blacklist endpoint
server/middleware/deprecation.ts	New middleware for API deprecation (well implemented)
server/lib/permissions.ts	Updated permission constants
server/lib/settings/index.ts	Updated settings interfaces and defaults
server/job/blocklistedTagsProcessor.ts	Renamed job processor with updated entity references
seerr-api.yml	Updated API documentation with new endpoints and deprecation notices
docs/	Updated documentation to use blocklist terminology

Comments suppressed due to low confidence (5)

server/entity/Blocklist.ts:20

• The Entity class has been renamed to Blocklist, but there's no corresponding database migration to rename the table from "blacklist" to "blocklist".

When TypeORM sees @Entity() without a specified table name, it will derive the table name from the class name, converting "Blocklist" to lowercase "blocklist". However, the actual database table is still named "blacklist" (as created in migration 1699901142442-AddBlacklist.ts).

This will cause the application to fail at runtime with errors like "table blocklist does not exist" when trying to query or insert data.

Solution: Either:

1. Add a database migration to rename the table from "blacklist" to "blocklist" for both SQLite and PostgreSQL, OR
2. Specify the table name explicitly in the Entity decorator: @Entity('blacklist')

Option 2 is safer if you want to avoid requiring a database migration.
server/entity/Blocklist.ts:48

• The property has been renamed from blacklistedTags to blocklistedTags, but the database column is still named blacklistedTags (as created in migration 1737320080282-AddBlacklistTagsColumn.ts).

TypeORM will try to map the property blocklistedTags to a database column with the same name, but the actual column is blacklistedTags. This will cause the application to fail when trying to query or save this field.

Solution: Either:

1. Add a database migration to rename the column from "blacklistedTags" to "blocklistedTags" for both SQLite and PostgreSQL, OR
2. Specify the column name explicitly in the Column decorator: @Column({ name: 'blacklistedTags', nullable: true, type: 'varchar' })

Option 2 is safer if you want to avoid requiring a database migration.
server/job/blocklistedTagsProcessor.ts:213

• The raw SQL WHERE clause references blist.blocklistedTags, but:

1. The table alias 'blist' refers to the Blocklist entity, which will try to query a "blocklist" table that doesn't exist (the actual table is "blacklist")
2. The column name should be "blacklistedTags" (not "blocklistedTags") to match the database schema

This query will fail at runtime. The fix depends on addressing the table and column name issues in the Blocklist entity (see other comments).
server/routes/blocklist.ts:48

• The query builder references property names that don't match the database schema:

• createQueryBuilder('blocklist') will try to query a "blocklist" table, but the actual table is "blacklist"
• blocklist.blocklistedTags references a column "blocklistedTags", but the actual column is "blacklistedTags"

These queries will fail at runtime. The fix depends on addressing the table and column name issues in the Blocklist entity (see comments on server/entity/Blocklist.ts).
server/job/blocklistedTagsProcessor.ts:188

• The repository update references blocklistedTags property which doesn't match the database column name "blacklistedTags". TypeORM will try to update a column named "blocklistedTags" which doesn't exist in the database schema.

This will cause the update operation to fail at runtime. The fix depends on addressing the column name issue in the Blocklist entity (see comment on server/entity/Blocklist.ts lines 47-48).

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.