fix(quota): enforce limits when editing requests with overrides #2190
+1
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where users with "Advanced Request" permissions could bypass their season limits by editing a pending request.
Previously, the quota check was skipped entirely if request overrides were present and the user was not an admin.
This PR simplifies the
useSWRcondition inTvRequestModal.tsxto ensure quotas are always loaded for the target user, preventing the bypass.I also added a check to ensure that admins (
MANAGE_REQUESTS) are not blocked by these quotas when editing requests for other users (loadingnullquota for them).AI Disclosure
I discussed the issue with an AI (Gemini 3 Pro) to verify the logic required for the fix. I wrote, reviewed, understood, and manually tested the solution myself.
How Has This Been Tested?
I tested these changes locally on macOS using Safari and Node v22.
Test Scenario 1: Verify the fix
Test Scenario 2: Verify Admin override
MANAGE_REQUESTSpermission).Screenshots / Logs (if applicable)
Checklist:
pnpm buildpnpm i18n:extract