-
Notifications
You must be signed in to change notification settings - Fork 15
Open
Labels
enhancementNew feature or requestNew feature or request
Description
The test suite currently uses/supports the staging environment in a few ways:
- the client-under-test CLI defines
--stagingas something the client should support - the action takes
environmentas argument: originally the idea was to run more tests on whatever environment was specified -- but later the addition of--trusted-rootand--signing-configmeant that there are now more economic ways to develop the suite than duplicating test assets: so currently there is only a single testtest_simplethat gets run whenenvironment: staging, this test only ensures that the client can successfully sign and verify with the given environment - loads of verification tests in practice use bundles from staging environment, but these tests use
--trusted-rootand don't require either--stagingorenvironment: staging
Plan:
- Keep --staging in the client-under-test CLI: we do want to encourage clients to include a feature like that
- Deprecate
environmentargument - Duplicate the
test_simple()test that current depends onenvironmentso that it tests production and staging in the same test run. This requires refactoring the client() fixture a bit but it should be a simplification
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request