Skip to content

Conversation

@jonathan-conder
Copy link

@jonathan-conder jonathan-conder commented Mar 12, 2025

Possible fix for #2257.

Tested using this test case:

func TestModifiedArgs(t *testing.T) {
	cmd := &Command{TraverseChildren: true}
	args := []string{"__complete", ""}
	cmd.SetArgs(args)
	if err := cmd.Execute(); err != nil {
		t.Errorf("Unexpected error: %v", err)
	}
	if len(args) != 2 || args[1] != "" {
		t.Error("Modified args")
	}
}

@CLAassistant
Copy link

CLAassistant commented Mar 12, 2025

CLA assistant check
All committers have signed the CLA.

@marckhouzam
Copy link
Collaborator

Before going this route, let's see if we can improve pflag with the required API as suggested in #1877

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants