feat: Added Range Slider Example #351
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added custom range slider code to markdown-content.tsx - Uncommented range slider component in Developer Notes
Range slider now updates the value in the input
MyLightIsOn
commented
Nov 19, 2025
| max="11" | ||
| value="10" | ||
| max="10" | ||
| step="1"> |
Collaborator
Author
There was a problem hiding this comment.
There's no styling here yet, but if the functionality checks out, I can spice it up.
MyLightIsOn
commented
Nov 19, 2025
| export const getMarkdownFunctionMap = ( | ||
| navigate: NavigateFunction | ||
| ): Record<string, (event: React.MouseEvent<Element>) => void> => ({ | ||
| ): Record<string, (event: React.SyntheticEvent) => void> => ({ |
Collaborator
Author
There was a problem hiding this comment.
I changed MouseEvent to SyntheticEvent to generalize the Markdown function handler type to accept any React synthetic event. This allows buttons/links/divs (mouse events) and inputs (form/change events) are all supported consistently.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While creating the script for this, I noticed that the previous version that shows up on internet archive did not sync the slider with the text. I'm guessing the originally it did work. I added this code in, but I changed the range slider text input to a span. Leaving it a text input would imply that the user could type something in the input and it would update the slider. We could do this too, but I though that was a lot of code bloat that doesn't serve the purpose that the example is trying to show. making it a span makes it read only.
My question is, should we add a live region to this to make it accessible and update the example to reflect?