Skip to content

Clean up flag variants in tests #18964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
arthurschreiber wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Clean up flag variants in tests #18964

arthurschreiber wants to merge 3 commits into from

Conversation

@arthurschreiber
Copy link
Member

@arthurschreiber arthurschreiber commented Dec 1, 2025

Description

Since v23 was released with all flags supporting both dasherized and underscored versions, we can switch all tests to use the dasherized versions exclusively on main (and all future versions).

Related Issue(s)

N/A

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

AI Disclosure

I used Claude Code to perform the changes.

@vitess-bot
Copy link
Contributor

vitess-bot bot commented Dec 1, 2025

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Dec 1, 2025
@arthurschreiber arthurschreiber added Type: Internal Cleanup and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Dec 1, 2025
@github-actions github-actions bot added this to the v24.0.0 milestone Dec 1, 2025
@arthurschreiber arthurschreiber added the Component: General Changes throughout the code base label Dec 1, 2025
@arthurschreiber arthurschreiber force-pushed the arthur/remove-flag-variants branch from 88ec9d5 to d61dd28 Compare December 1, 2025 10:53
@arthurschreiber arthurschreiber force-pushed the arthur/remove-flag-variants branch from d61dd28 to 23da09a Compare December 1, 2025 10:57
arthurschreiber
arthurschreiber commented Dec 1, 2025
View reviewed changes
go/test/endtoend/cluster/vtbackup_process.go
//Backup Arguments are not optional
utils.GetFlagVariantForTestsByVersion("--file-backup-storage-root", vtbackupVer): vtbackup.BackupStorageImplementation,
"--file-backup-storage-root": vtbackup.FileBackupStorageRoot,
"--backup-storage-implementation": vtbackup.BackupStorageImplementation,
Copy link
Member Author

@arthurschreiber arthurschreiber Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this was actually wrong before (using --file-backup-storage-root but then passing the value of vtbackup.BackupStorageImplementation).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal will be requested when the pull request is marked ready for review harshit-gangal is a code owner

@systay systay Awaiting requested review from systay systay will be requested when the pull request is marked ready for review systay is a code owner

@shlomi-noach shlomi-noach Awaiting requested review from shlomi-noach shlomi-noach will be requested when the pull request is marked ready for review shlomi-noach is a code owner

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps rohit-nayak-ps will be requested when the pull request is marked ready for review rohit-nayak-ps is a code owner

@timvaillancourt timvaillancourt Awaiting requested review from timvaillancourt timvaillancourt will be requested when the pull request is marked ready for review timvaillancourt is a code owner

@mattlord mattlord Awaiting requested review from mattlord mattlord will be requested when the pull request is marked ready for review mattlord is a code owner

@beingnoble03 beingnoble03 Awaiting requested review from beingnoble03 beingnoble03 will be requested when the pull request is marked ready for review beingnoble03 is a code owner

@frouioui frouioui Awaiting requested review from frouioui frouioui will be requested when the pull request is marked ready for review frouioui is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

Component: General Changes throughout the code base Type: Internal Cleanup

Projects

None yet

Milestone

v24.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@arthurschreiber