fix: Replace ASCII with UTF-8 encoding in load_bytes() #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes UnicodeDecodeError when kernel processes messages containing
non-ASCII characters (e.g., UTF-8 paths, locale-specific metadata).
The Jupyter protocol uses UTF-8 encoding for JSON messages by default
(RFC 8259), but load_bytes() was hardcoded to use ASCII decoding.
This caused kernel crashes for users with:
- Non-ASCII usernames or paths
- Non-English system locales
- Any workspace containing UTF-8 characters
Changes:
- xonsh_jupyter/kernel.py:38: b.decode('ascii') -> b.decode('utf-8')
Impact: Makes xonsh kernel usable in international environments.
anki-code
approved these changes
Nov 21, 2025
Member
|
Thanks @mapix-etnc ! |
Member
|
@jnoortheen please make a new release. Thanks! |
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes UnicodeDecodeError when kernel processes messages containing non-ASCII characters (e.g., UTF-8 paths, locale-specific metadata).
The Jupyter protocol uses UTF-8 encoding for JSON messages by default (RFC 8259), but load_bytes() was hardcoded to use ASCII decoding.
This caused kernel crashes for users with:
Changes:
Impact: Makes xonsh kernel usable in international environments.