Rely on the default logger to log fatal error messages

bradwilson · bradwilson · commit 10dad85dc7af · 2025-11-27T13:05:18.000-08:00
diff --git a/src/xunit.runner.visualstudio/Sinks/VsExecutionSink.cs b/src/xunit.runner.visualstudio/Sinks/VsExecutionSink.cs
@@ -122,8 +122,6 @@ void HandleErrorMessage(MessageHandlerArgs<IErrorMessage> args)
 	{
 		ExecutionSummary.Errors++;
 
-		logger.LogError("Catastrophic failure: {0}", ExceptionUtility.CombineMessages(args.Message));
-
 		HandleCancellation(args);
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -122,8 +122,6 @@ void HandleErrorMessage(MessageHandlerArgs<IErrorMessage> args)`
`122`	`122`	`{`
`123`	`123`	`ExecutionSummary.Errors++;`
`124`	`124`
`125`		`- logger.LogError("Catastrophic failure: {0}", ExceptionUtility.CombineMessages(args.Message));`
`126`		`-`
`127`	`125`	`HandleCancellation(args);`
`128`	`126`	`}`
`129`	`127`