Move Azure Login closer to signing, and collect MSBuild binlogs

Author: bradwilson

.github/workflows/ci-signed.yaml

@@ -36,22 +36,33 @@ jobs:
       - name: Get .NET information
         run: dotnet --info
 
+      - name: "Build target: BuildAll"
+        run: dotnet run --project tools/builder --no-launch-profile -- BuildAll --timing
+
       - name: Login to Azure CLI
         uses: azure/login@v2
         with:
           client-id: ${{ vars.KEYVAULT_APP_ID }}
           tenant-id: ${{ vars.KEYVAULT_TENANT_ID }}
           subscription-id: ${{ vars.KEYVAULT_SUBSCRIPTION_ID }}
 
-      - name: "Build target: BuildAll & PublishPackages"
+      - name: "Build target: PublishPackages"
         env:
           PUSH_APIKEY: ${{ secrets.FEEDZ_PUSH_KEY }}
           PUSH_URI: ${{ vars.FEEDZ_PUSH_URL }}
           SIGN_APP_ID: ${{ vars.KEYVAULT_APP_ID }}
           SIGN_CERT_NAME: ${{ vars.KEYVAULT_CERT_NAME }}
           SIGN_TIMESTAMP_URI: ${{ vars.KEYVAULT_TIMESTAMP_URL }}
           SIGN_VAULT_URI: ${{ vars.KEYVAULT_URL }}
-        run: dotnet run --project tools/builder --no-launch-profile -- BuildAll PublishPackages --timing
+        run: dotnet run --project tools/builder --no-launch-profile -- PublishPackages --timing
+
+      - name: "Upload artifact: build"
+        uses: actions/upload-artifact@v4
+        with:
+          name: build
+          path: artifacts/build
+          compression-level: 9
+        if: always()
 
       - name: "Upload artifact: test"
         uses: actions/upload-artifact@v4

tools/builder/common

@@ -1,3 +1,4 @@
+using System.IO;
 using System.Threading.Tasks;
 using Xunit.BuildTools.Models;
 
@@ -9,6 +10,8 @@ public static partial Task PerformBuild(BuildContext context)
 	{
 		context.BuildStep("Compiling binaries");
 
-		return context.Exec("dotnet", $"msbuild -nologo -maxCpuCount -restore:False -verbosity:{context.Verbosity} -p:Configuration={context.ConfigurationText} -p:PackageOutputPath={context.PackageOutputFolder}");
+		var buildLog = Path.Combine(context.BuildArtifactsFolder, "build.binlog");
+
+		return context.Exec("dotnet", $"msbuild -nologo -maxCpuCount -restore:False -verbosity:{context.Verbosity} -property:Configuration={context.ConfigurationText} -p:PackageOutputPath={context.PackageOutputFolder} -binaryLogger:{buildLog}");
 	}
 }