fix memory leak

- closed the request body in admission webhook
- closed filters after validation
- added a check in the lifo filter to ensure the queue is not nil during closing

Signed-off-by: Veronika Volokitina <[email protected]>

Author: vlktna

dataclients/kubernetes/admission/admission.go

@@ -71,6 +71,8 @@ func Handler(admitter admitter) http.HandlerFunc {
 			return
 		}
 
+		defer r.Body.Close()
+
 		body, err := io.ReadAll(r.Body)
 		if err != nil {
 			log.Errorf("Failed to read request: %v", err)

filters/scheduler/lifo.go

@@ -235,7 +235,9 @@ func (l *lifoFilter) GetQueue() *scheduler.Queue {
 
 // Close will cleanup underlying queues
 func (l *lifoFilter) Close() error {
-	l.queue.Close()
+	if l.queue != nil {
+		l.queue.Close()
+	}
 	return nil
 }
 
@@ -286,7 +288,9 @@ func (l *lifoGroupFilter) GetQueue() *scheduler.Queue {
 
 // Close will cleanup underlying queues
 func (l *lifoGroupFilter) Close() error {
-	l.queue.Close()
+	if l.queue != nil {
+		l.queue.Close()
+	}
 	return nil
 }
 

routing/datasource.go

@@ -475,7 +475,13 @@ func processTreePredicates(r *Route, predicateList []*eskip.Predicate) error {
 // ValidateRoute processes a route definition for the routing table.
 // This function is exported to be used by validation webhooks.
 func ValidateRoute(o *Options, def *eskip.Route) (*Route, error) {
-	return processRouteDef(o, mapPredicates(o.Predicates), def)
+	route, err := processRouteDef(o, mapPredicates(o.Predicates), def)
+	if err != nil {
+		return nil, err
+	}
+
+	defer closeFilterClosers(route.Filters)
+	return route, nil
 }
 
 // processes a route definition for the routing table
@@ -489,6 +495,11 @@ func processRouteDef(o *Options, cpm map[string]PredicateSpec, def *eskip.Route)
 	if err != nil {
 		return nil, err
 	}
+	defer func() {
+		if err != nil {
+			closeFilterClosers(fs)
+		}
+	}()
 
 	def, err = mergeLegacyNonTreePredicates(def)
 	if err != nil {
@@ -563,15 +574,19 @@ type routeTable struct {
 func (rt *routeTable) close() {
 	rt.once.Do(func() {
 		for _, route := range rt.routes {
-			for _, f := range route.Filters {
-				if fc, ok := f.Filter.(filters.FilterCloser); ok {
-					fc.Close()
-				}
-			}
+			closeFilterClosers(route.Filters)
 		}
 	})
 }
 
+func closeFilterClosers(rfs []*RouteFilter) {
+	for _, f := range rfs {
+		if fc, ok := f.Filter.(filters.FilterCloser); ok {
+			_ = fc.Close()
+		}
+	}
+}
+
 // receives the next version of the routing table on the output channel,
 // when an update is received on one of the data clients.
 func receiveRouteMatcher(o Options, out chan<- *routeTable, quit <-chan struct{}) {