Skip to content

reset cw2025 branch #3741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
MustafaSaber wants to merge 2 commits into from
Closed

reset cw2025 branch #3741

MustafaSaber wants to merge 2 commits into from

Conversation

@MustafaSaber
Copy link
Member

@MustafaSaber MustafaSaber commented Nov 18, 2025

see subject

szuecs and others added 2 commits November 18, 2025 10:33
@szuecs
Gh action/labeler (#3737)
ce21a33 
Use commits from cw2025 such that the labeler works during code freeze


````
% git cherry-pick e23559c
[gh-action/labeler c4dc064] automate: pr label cw2025 for convenience (#3724)
 Date: Mon Nov 10 22:28:21 2025 +0100
 1 file changed, 7 insertions(+)
 create mode 100644 .github/labeler.yml
% git cherry-pick 5192763
[gh-action/labeler fdba813] fix: yaml indentation in labeler.yml (#3732)
 Date: Fri Nov 14 19:54:55 2025 +0100
 1 file changed, 6 insertions(+), 2 deletions(-)
````

---------

Signed-off-by: Sandor Szücs <[email protected]>
@MustafaSaber
actions: add workflow to enable labeler (#3740)
7e02c43 
follow up on #3737

Signed-off-by: Mustafa Abdelrahman <[email protected]>
@github-advanced-security
Copy link

github-advanced-security bot commented Nov 18, 2025

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 18, 2025
View reviewed changes
.github/workflows/labeler.yaml
@@ -0,0 +1,13 @@
name: "Pull Request Labeler"

Check failure

Code scanning / Scorecard

Token-Permissions High

score is 9: no topLevel permission defined
Remediation tip: Visit https://app.stepsecurity.io/secureworkflow.
Tick the 'Restrict permissions for GITHUB_TOKEN'
Untick other options
NOTE: If you want to resolve multiple issues at once, you can visit https://app.stepsecurity.io/securerepo instead.
Click Remediation section below for further remediation help
.github/workflows/labeler.yaml
pull-requests: write
runs-on: ubuntu-latest
steps:
- uses: actions/labeler@v6

Check warning

Code scanning / Scorecard

Pinned-Dependencies Medium

score is 8: GitHub-owned GitHubAction not pinned by hash
Remediation tip: update your workflow using https://app.stepsecurity.io
Click Remediation section below for further remediation help
@MustafaSaber MustafaSaber added the minor no risk changes, for example new filters label Nov 18, 2025
@zalando-robot
Copy link

zalando-robot commented Nov 18, 2025

Deployment Checklist

This change falls under the deployment policy.

💁 Since Nov 10th, we are in the RED deployment zone. This means all changes released to production must adhere to the following requirements:

  • Detailed release notes are provided in this PR’s description.
  • Thorough load-testing has been performed, and is documented in the description/comment.
  • You can enable/disable the change via feature toggles, and have confirmed these toggles work as expected.
  • Technical review: A Principal Engineer, Engineering Manager or Head of Engineering have green-lit your changes, and the reviewer is named in the description/comments.
  • Application Owner (Director+) approval is given about the PR, and the approver is named in the description/comments.

👉 Regardless of which boxes you click in this comment, merge/deployment will not be blocked.
Reports about deployment policy adherence will be circulated daily.

@szuecs
Copy link
Member

szuecs commented Nov 18, 2025

Why should we do this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

minor no risk changes, for example new filters

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MustafaSaber @zalando-robot @szuecs