metrics: remove invalid routes deletion #3776
Open
+27
−99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlktna
force-pushed
the
remove-invalid-route-metric-delition
branch
from
285d7f4 to
bc7cf9a
Compare
When validation is enabled and a new invalid route is created, it gets rejected and a metric is emitted. But when the route is later fixed, the old metric is not removed. Once the route is fixed, there is no error, so the corrected route no longer matches the old metric key. Signed-off-by: Veronika Volokitina <[email protected]>
vlktna
force-pushed
the
remove-invalid-route-metric-delition
branch
from
bc7cf9a to
8316d1a
Compare
szuecs
reviewed
Dec 5, 2025
| // This function is exported to be used by validation webhooks. | ||
| func ValidateRoute(o *Options, def *eskip.Route) (*Route, error) { | ||
| return processRouteDef(o, mapPredicates(o.Predicates), def) | ||
| return processRouteDef(o, mapPredicates(o.Predicates), def) // |
Member
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When validation is enabled and a new invalid route is created, it gets rejected and a metric is emitted. But when the route is later fixed, the old metric is not removed. Once the route is fixed, there is no error, so the corrected route no longer matches the old metric key.