feat: applied suggestions from review (#1536)

tkrop · SmilyOrg · ePaul · web-flow · commit 64994e44cf56 · 2025-07-04T16:22:52.000+02:00
Co-authored-by: Miha Lunar &lt;mlunar@gmail.com&gt;
Co-authored-by: Paŭlo Ebermann &lt;paul.ebermann@zalando.de&gt;
diff --git a/server/zally-ruleset-zalando/src/main/kotlin/org/zalando/zally/ruleset/zalando/DateTimePropertiesSuffixRule.kt b/server/zally-ruleset-zalando/src/main/kotlin/org/zalando/zally/ruleset/zalando/DateTimePropertiesSuffixRule.kt
@@ -13,7 +13,7 @@ import org.zalando.zally.rule.api.Violation
     ruleSet = ZalandoRuleSet::class,
     id = "235",
     severity = Severity.SHOULD,
-    title = "Name date/time properties using the common suffix"
+    title = "Name date/time properties using the common conventions"
 )
 class DateTimePropertiesSuffixRule(rulesConfig: Config) {
 
diff --git a/server/zally-ruleset-zalando/src/test/kotlin/org/zalando/zally/ruleset/zalando/DateTimePropertiesSuffixRuleTest.kt b/server/zally-ruleset-zalando/src/test/kotlin/org/zalando/zally/ruleset/zalando/DateTimePropertiesSuffixRuleTest.kt
@@ -107,7 +107,7 @@ class DateTimePropertiesSuffixRuleTest {
     }
 
     @Test
-    fun `should fail on prefix _at and succeed on prefix patterns`() {
+    fun `should fail on prefix at_ and succeed on prefix patterns`() {
         @Language("YAML")
         val content = """
             openapi: '3.0.1'

Original file line number	Diff line number	Diff line change
`@@ -13,7 +13,7 @@ import org.zalando.zally.rule.api.Violation`
`13`	`13`	`ruleSet = ZalandoRuleSet::class,`
`14`	`14`	`id = "235",`
`15`	`15`	`severity = Severity.SHOULD,`
`16`		`- title = "Name date/time properties using the common suffix"`
	`16`	`+ title = "Name date/time properties using the common conventions"`
`17`	`17`	`)`
`18`	`18`	`class DateTimePropertiesSuffixRule(rulesConfig: Config) {`
`19`	`19`
Original file line number	Diff line number	Diff line change
`@@ -107,7 +107,7 @@ class DateTimePropertiesSuffixRuleTest {`
`107`	`107`	`}`
`108`	`108`
`109`	`109`	`@Test`
`110`		- fun `should fail on prefix _at and succeed on prefix patterns`() {
	`110`	+ fun `should fail on prefix at_ and succeed on prefix patterns`() {
`111`	`111`	`@Language("YAML")`
`112`	`112`	`val content = """`
`113`	`113`	`openapi: '3.0.1'`