[AzureStackHci] Generate SDK code from Swagger #54301
Open
+30,400
−1,972
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
mzhongl524
requested review from
ArcturusZhang and
ArthurMa1978
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR generates SDK code from Swagger specifications for the Azure Stack HCI service. The main purpose is to add backward compatibility methods to the ArmHciModelFactory class to support existing code while introducing new properties to the data models.
Key changes:
- Removed unused namespace import (
Azure.ResourceManager.Resources.Models) - Added multiple
EditorBrowsable(EditorBrowsableState.Never)factory methods for backward compatibility when new properties are introduced to existing models - Each new factory method forwards calls to the current implementation with
defaultvalues for newly added parameters
| /// <param name="interfaceDescription"> Interface Description of NIC. </param> | ||
| /// <param name="componentId"> Component Id of NIC. </param> | ||
| /// <param name="driverVersion"> Driver Version of NIC. </param> | ||
| /// <param name="ipv4Address"> Subnet Mask of NIC. </param> |
There was a problem hiding this comment.
The parameter documentation for ipv4Address incorrectly states 'Subnet Mask of NIC' when it should describe the IPv4 address. The subnet mask is correctly documented on line 472.
Suggested change
| /// <param name="ipv4Address"> Subnet Mask of NIC. </param> | |
| /// <param name="ipv4Address"> IPv4 address of NIC. </param> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
spec pr: Azure/azure-rest-api-specs#38980.
Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.