-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Migrate Azure.AI.Language.QuestionAnswering.Authoring to new generator #54330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: JoshLove-msft <[email protected]>
Co-authored-by: JoshLove-msft <[email protected]>
...anguage/Azure.AI.Language.QuestionAnswering.Authoring/src/QuestionAnsweringAuthoringError.cs
Show resolved
Hide resolved
...uage.QuestionAnswering.Authoring/api/Azure.AI.Language.QuestionAnswering.Authoring.net8.0.cs
Show resolved
Hide resolved
....QuestionAnswering.Authoring/src/Generated/LanguageQuestionAnsweringAuthoringModelFactory.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR successfully migrates Azure.AI.Language.QuestionAnswering.Authoring from the legacy TypeSpec C# emitter to the new Azure generator (@azure-typespec/http-client-csharp). The migration updates the emitter path, regenerates code with the new generator, removes obsolete legacy customizations, and adds targeted workarounds for generator gaps.
Key Changes
- Updated emitter configuration to use the new Azure TypeSpec generator
- Removed legacy customization files using deprecated
CodeGenModel,CodeGenType, andCodeGenSuppressattributes - Added workaround files (
ImportContentType.cs,ImportJobOptions.cs,QuestionAnsweringAuthoringClientCustomizations.cs) to address generator gaps - Updated client to use
Pipelineproperty instead of_pipelinefield - Regenerated all models with new serialization patterns using
_additionalBinaryDataPropertiesinstead of_serializedAdditionalRawData
Reviewed changes
Copilot reviewed 12 out of 146 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tsp-location.yaml | Updated emitter package path and commit reference |
| QuestionAnsweringAuthoringClient.cs | Changed _pipeline field to Pipeline property |
| QuestionAnsweringAuthoringClientCustomizations.cs | Added helper overloads for Import operations |
| ImportContentType.cs | New workaround for missing content type referenced by convenience methods |
| ImportJobOptions.cs | Placeholder for missing FileUri property (workaround) |
| QuestionAnsweringAuthoringError*.cs | Removed - now generated by new emitter |
| Generated/Models/* | Regenerated with new serialization patterns and ResponseError instead of custom error types |
| Generated/QuestionAnsweringAuthoringClient.RestClient.cs | New protocol layer implementation |
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
Description
Migrates
Azure.AI.Language.QuestionAnswering.Authoringfrom the legacy TypeSpec C# emitter (@azure-tools/typespec-csharp) to the new Azure generator (@azure-typespec/http-client-csharp).Changes
eng/azure-typespec-http-client-csharp-emitter-package.jsonIncludeAutorestDependency,System.Text.Jsonreference, and AZC0012 suppressiontsp-client updateCodeGenType,CodeGenModel,CodeGenSuppress)ImportContentType.cs- Missing type referenced by generated convenience methodsImportJobOptions.cs- MissingFileUripropertyQuestionAnsweringAuthoringClientCustomizations.cs- Helper overloads for Import operationsPipelinepropertyAll existing tests pass (25 passed, 9 skipped live tests).
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.