Add Node Auto Provisioning Benchmark in STLS Bootstrap Suite #960
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
December 4, 2025 10:43
KananMehta
requested review from
anson627,
sumanthreddy29,
vittoriasalim,
wonderyl and
xinWeiWei24
as code owners
KananMehta
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds infrastructure configuration files for the stls-bootstrap-nap test scenario, which combines Secure TLS Bootstrapping with Node Auto Provisioning (NAP/Karpenter) testing. The scenario is referenced by an existing pipeline file (pipelines/perf-eval/Secure TLS Bootstrap Benchmark/node-auto-provisioning.yml) and these files provide the necessary Terraform and Kubernetes configurations.
- Adds terraform test inputs for Azure with westus2 region configuration
- Adds terraform configuration enabling Secure TLS Bootstrapping feature with NAP mode
- Adds Karpenter NodePool definitions for both on-demand and spot instances
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| scenarios/perf-eval/stls-bootstrap-nap/terraform-test-inputs/azure.json | Adds test input JSON with run_id and westus2 region for terraform validation |
| scenarios/perf-eval/stls-bootstrap-nap/terraform-inputs/azure.tfvars | Adds terraform variables configuring AKS with Secure TLS Bootstrapping and Node Auto Provisioning mode |
| scenarios/perf-eval/stls-bootstrap-nap/kubernetes/karpenter_nodepool.azure.yml | Adds Karpenter NodePool and AKSNodeClass definitions for on-demand and spot workloads |
| aks_name = "nap" | ||
| sku_tier = "standard" | ||
| aks_custom_headers = [ | ||
| "AKSHTTPCustomFeatures=Microsoft.ContainerService/EnableSecureTLSBootstrapping" |
There was a problem hiding this comment.
this won't have NAP create nodes using secure TLS bootstrapping, we'd need to enable the feature in the particular sub/region
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a NAP test for the STLS benchmark suite. This is mostly 1:1 with the standard NAP test but adds the STLS custom header to enable the feature.