Expire sessions after 1 hour #42
Merged
+26
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like something changed with either GitHub or browsers such that GitHub is frequently giving 401s. I'm not sure whether that's because they're expiring tokens more readily, or sessions are lasting longer than they used to. Ideally Octocrab would notice 401s and force a re-auth, but it doesn't have an obvious hook for that. Instead, just expire sessions after an hour so that we will stop seeing existing tokens, and will automatically redirect people to fetch new tokens.
LonMcGregor
reviewed
Dec 8, 2025
Collaborator
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
One comment about rust
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like something changed with either GitHub or browsers such that GitHub is frequently giving 401s. I'm not sure whether that's because they're expiring tokens more readily, or sessions are lasting longer than they used to.
Ideally Octocrab would notice 401s and force a re-auth, but it doesn't have an obvious hook for that. Instead, just expire sessions after an hour so that we will stop seeing existing tokens, and will automatically redirect people to fetch new tokens.