Skip to content

Conversation

@gformisa
Copy link

@gformisa gformisa commented Nov 6, 2025

What are the changes introduced in this pull request?

  • Show name,stream,version,context in the breadcrumb menu.
  • Add a custom field in the backend API view.

Summary by Sourcery

Add a composite name_stream_version_context field to the module_streams API and update the frontend to display it in the breadcrumb menu

Enhancements:

  • Add name_stream_version_context node to module_streams API JSON response
  • Use name_stream_version_context in ModuleStreamDetails for breadcrumb labels

theforeman/foreman#10764

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

 * Show name,stream,version,context in the breadcrumb menu.
 * Add a custom field in the backend API view.
@ianballou
Copy link
Member

@gformisa looks like you just need to re-run the snapshot generation - seems it was updated before we could get this merged.

@ianballou
Copy link
Member

Looking great, thanks!
image

So it's just the snapshot regeneration then. I might be able to help get to it.

@ianballou
Copy link
Member

Lucky, looks like you just need to delete the snap test. I'll approve this and we can merge once that is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants