-
Notifications
You must be signed in to change notification settings - Fork 2
Patch for linux 2 #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
clang analyzer makes lots of files there.
This fixes leftovers from the prior Nexus-Mods#5
|
@NicBOMB I might be wrong but as far as I remember libloot was fairly complex to build - maybe that's limited to windows. But since libloot binaries are hosted on github, downloading those dynamically for the current platform might be easier. |
@TanninOne I built easily on my second try since I already had most of the depends. I was only missing boost, installed it, then libloot compiled. $ ls build
CMakeCache.txt CMakeFiles cmake_install.cmake CPackConfig.cmake CPackSourceConfig.cmake external generated libloot_internals_tests libloot.so libloot_tests LICENSE Makefile Morrowind Oblivion README.md Skyrim SkyrimSEThe recommended build commands seemed excessive only since my environment is already running the latest/required versions of the build tools.
I agree, we should fetch those prebuilt platform binaries rather than additionally require more build tools like the Rust toolkit to build Vortex. |
|
I'll open a new PR once libloot gets a new release following loot/libloot#87 (comment) so we can begin getting those platform specific binaries dynamically. For now, I've included the binary from the latest libloot v18 for linux. This PR can be reviewed and merged. |
@TanninOne As of libloot v0.18.3 release artifacts hosted on github use a simple release name. They can be automatically downloaded easily, however, those archives are only available with xz and 7z compression. Those compression formats are not supported by node-tar, node-stream-zip, or node (as in download_lz4.js). In order to use those releases something like |
|
@NicBOMB The best way to deal with that would probably be to use https://github.com/Nexus-Mods/node-7z |
Includes an updated build script (libloot.js) and bindings.gyp fixes.
remove autogypi
prebuild still depends on an outdated version of node-gyp. This causes builds to fail in vortex_devel, but not standalone builds. node-gyp is death by a thousand cuts.
This fixes leftovers from the prior #5.
However, my comment about the loot library linking error is still relevant and a fixing commit could be added to this PR before merging.