Skip to content

Conversation

@daberni
Copy link
Contributor

@daberni daberni commented Dec 6, 2025

TokenProvider.GetAsync() was declared with visibility modifier internal. This resulted in a generated class which could only be implemented in the same module, although the class itself is declared as public making it accessible globally.

In the use case of providing an SDK where the Token is provided from some external source this would not be supported right now. By declaring GetAsync() public, anyone can implement its own TokenProvider and register it in the IServiceCollection for automatic dependency lookup.

At the same point I cleared up the unclear declaration of a _token collection, which only is used from RateLimitProvider. RateLimitProvider now only uses the TokenContainer directly, without roundtrip of TokenProvider._tokens.

Any other implementatio nof TokenProvider could declare its own list if necessary.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@mandrean (2017/08) @shibayan (2020/02) @Blackclaws (2021/03) @lucamazzanti (2021/05) @iBicha (2023/07)

@daberni daberni force-pushed the feature/csharp-tokenprovider branch from 6a47cc9 to 9acccba Compare December 6, 2025 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant