Fix graphql where clause when database schema is configured

[mdameer]

Fix #14627

The old code Dialect.QuoteForTableName(tableAlias, _configuration.Schema) was adding the schema to a table alias (e.g., ContentItemIndex_a1), which caused the issue. I updated it to use Dialect.QuoteForAliasName(tableAlias).

[hishamco]

Can we have a unit test for that if it's possible

[mdameer]

Can we have a unit test for that if it's possible

Sure I will do

[mdameer]

@hishamco I forgot to mention that this issue affects the tenant when specifying a table schema during setup. As far as I know, SQLite doesn't support schemas. If you have any ideas on how we can implement unit tests for this service, please let me know.

[hishamco]

What about a functional test?

[mdameer]

What about a functional test?

@hishamco Done

[hishamco]

I will have a look ASAP

[hishamco]

@hyzx86 @gvkries do you have any feedback on this?

[gvkries]

Omitting the database schema looks suspicious to me. The schema is added before the table name correctly in YesSql, like $"[{schema}].[{tableName}]".
The error described in the bug report must be caused by something else.

[hyzx86]

Omitting the database schema looks suspicious to me. The schema is added before the table name correctly in YesSql, like $"[{schema}].[{tableName}]".

Good point!
@mdameer Can we make sure that the architecture was developed at the same time as the table alias was created?

[mdameer]

@hyzx86 @gvkries hope I understood correctly. This area deals with table aliases, not table names. Adding the schema to a table alias is incorrect, so I switched the implementation to quote the table alias instead. If this doesn't address the issue, please provide further details.

[gvkries]

@hyzx86 @gvkries hope I understood correctly. This area deals with table aliases, not table names. Adding the schema to a table alias is incorrect, so I switched the implementation to quote the table alias instead. If this doesn't address the issue, please provide further details.

I see, thanks for the explanation.

[hishamco]

Anything to be added here @gvkries? What about your last suggestion #16364 (comment)

[gvkries]

Anything to be added here @gvkries? What about your last suggestion #16364 (comment)

I think that is another bug and should be fixed, but someone with more insights to this code should have a look. @mdameer seems to have grokked this part ;-)

[hishamco]

Thanks for your contribution @mdameer