Skip to content

Conversation

@xtomas
Copy link
Contributor

@xtomas xtomas commented Oct 3, 2025

  • add content type filter for ListPart administration
  • optimize loading contained content types in ListPartDriver

Screenshots of the result:

Content Type filter added to the right of the text search input
image

Selecting content types
image

Content types filter selected and applied
image

Implements
#18429

Tomáš Jákl added 2 commits October 3, 2025 11:46
+ add content type filter for ListPart administration
* optimize loading contained content types in ListPartDriver

OrchardCMS#18429
@MikeAlhayek
Copy link
Member

Thanks for this PR. I would add the filters in the place place as the management screen for consistency and re-usability. Here is where these filter should go. This way, we can "may be in other PR" add sort and other filters if needed.

image

@Piedone
Copy link
Member

Piedone commented Oct 14, 2025

@xtomas have you seen Mike's comment?

@xtomas
Copy link
Contributor Author

xtomas commented Oct 15, 2025

@Piedone yes I have already seen Mike's comment. I actually work on it in my git repository. On a copied Lists code just to be sure it will be available for my project even if my PR will not yet be finished and 3.x version not released.
If it will work well, I will update this PR with functional and tested solution.

I also had and idea to enable filtering content picker field in contained types only (for example two content types in a list part and one picking from other, let's say Partner with list of branches and discounts where discount can multiple pick from partner's branches). It was easy to implement but I actually do not need it anymore due to business requirements change. And it is not easy to describe in UI.

@Piedone
Copy link
Member

Piedone commented Oct 15, 2025

OK, thanks, let us know in a comment here once you've updated the PR.

The contained-type only feature is not something that would be generally too useful, I think, but I'm not sure I fully understand what it's about.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants