-
Notifications
You must be signed in to change notification settings - Fork 641
security(CASA-49): add cache-control headers to prevent caching #1036
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
orhanrauf
wants to merge
3
commits into
main
Choose a base branch
from
security/casa-49-add-cache-control-headers
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add middleware to set Cache-Control: no-store, private headers on all /api/v1/ endpoints to prevent caching of sensitive data at any layer. - Add cache_control_middleware() in api/middleware.py - Register middleware in main.py middleware stack - Respects existing headers (SSE endpoints unchanged) Meets CASA-49 compliance requirements.
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 2 files
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 2 files
felixschmetz
approved these changes
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements CASA-49 compliance by adding Cache-Control middleware to prevent caching of sensitive data.
Changes
Sets Cache-Control: no-store, private on all /api/v1/ endpoints while respecting existing SSE headers.
Compliance
Meets CASA-49 requirements for preventing caching of sensitive data in server components.
Closes ENG-187
Summary by cubic
Add middleware that sets Cache-Control: no-store, private on all API responses to prevent caching of sensitive data. Keeps existing Cache-Control headers intact (e.g., SSE) and fulfills CASA-49.