Update to_date udf function to support a consistent set of argument types #19134
+104
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
Jefffrey
approved these changes
Dec 7, 2025
| } | ||
| } | ||
| } | ||
| Float16 | Float32 | Float64 => { |
Contributor
There was a problem hiding this comment.
Suggested change
| Float16 | Float32 | Float64 => { | |
| Float16 | Float32 | Float64 | Decimal32(_, _) | Decimal64(_, _) | Decimal128(_, _) | Decimal256(_, _) => { |
Then in the description can simplify as:
Supports strings, numeric and timestamp types as input.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Improved type support for to_date function.
What changes are included in this PR?
Code, slt, updated docs.
Are these changes tested?
Yes
Are there any user-facing changes?
More types supported.