feat: Impl InMemoryCatalog's UpdateTable #386
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WZhuo
force-pushed
the
memory_catalog
branch
4 times, most recently
from
55d3900 to
67a5362
Compare
zhjwpku
reviewed
Dec 5, 2025
HuaHuaY
reviewed
Dec 5, 2025
| const std::vector<std::unique_ptr<TableRequirement>>& requirements, | ||
| const std::vector<std::unique_ptr<TableUpdate>>& updates) { | ||
| return NotImplemented("update table"); | ||
| std::unique_lock lock(mutex_); |
Contributor
There was a problem hiding this comment.
Suggested change
| std::unique_lock lock(mutex_); | |
| std::lock_guard guard(mutex_); |
Use std::lock_guard instead of std::unique_lock if we don't need to move the guard.
Contributor
Author
There was a problem hiding this comment.
I think it can be optimized with ReadWriteLock later.
Contributor
There was a problem hiding this comment.
I agree that we may be able to replace the lock type with std::shared_lock. If you don't do that in this PR, I hope that you can replace with std::lock_guard first. Because we have merged a PR #398 which replaced the other unique_lock in this file.
Member
|
This PR seems have carried other unrelated changes. Could you fix it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.