-
Notifications
You must be signed in to change notification settings - Fork 111
refactor(dataset): Redirect multipart upload through File Service #4114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Contributor
|
Thanks for checking the details. If you create a new PR, please mention it in this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
DB / schema
dataset_upload_sessionanddataset_upload_session_parttables to track multipart upload sessions, per-part status, and S3/LakeFS metadata.Backend (
DatasetResource)Partially new multipart upload API:
POST /dataset/multipart-upload?type=init→ creates a LakeFS multipart session, stores it in DB, and returns anuploadToken.POST /dataset/multipart-upload/part?token=...&partNumber=...→ streams a single part to the presigned URL, with row-level locking andPENDING/UPLOADING/COMPLETEDstate transitions.POST /dataset/multipart-upload?type=finish|abort→ completes or aborts the LakeFS multipart upload and cleans up DB records.Keep existing access control and dataset permissions enforced on all new endpoints.
Frontend service (
dataset.service.ts)Main changes in
multipartUpload(...):initto getuploadToken./multipart-upload/partstreaming them with concurrency.Frontend component (
dataset-detail.component.ts)uploadTokento cancel/abort.Any related issues, documentation, discussions?
Closes #4110
How was this PR tested?
Manually uploaded large files via the dataset detail page (single and multiple), checked:
COMPLETED, LakeFS object present, dataset version creation works).Was this PR authored or co-authored using generative AI tooling?
GPT partial use.