Skip to content

Conversation

@larivierec
Copy link

@larivierec larivierec commented Mar 3, 2025

🎟️ Tracking

Closes #172

📔 Objective

Allows the parsing of json/yaml structures inside bitwarden secrets so that more than one value can be exported per secret.

⏰ Reminders before review

  • Contributor guidelines followed ✅
  • All formatters and local linters executed and passed ✅
  • Written new unit and / or integration tests where applicable ✅
  • Protected functional changes with optionality (feature flags) ✅
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

Commit Notes:

  • add support for parsing yaml and json structures in bitwarden secrets
  • add unit tests for use cases
  • update readme to reflect the new changes
  • add three flags, parse_yaml, parse_json and transform_keys to enable the feature
  • will auto convert to uppercase

@CLAassistant
Copy link

CLAassistant commented Mar 3, 2025

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@bitwarden-bot
Copy link

Thank you for your contribution! We've added this to our internal Community PR board for review.
ID: SM-1466

@bitwarden-bot bitwarden-bot changed the title feat(structures): parse yaml and json structures in secrets [SM-1466] feat(structures): parse yaml and json structures in secrets Mar 3, 2025
@larivierec larivierec force-pushed the main branch 4 times, most recently from e3939e6 to f049539 Compare March 3, 2025 21:40
@larivierec
Copy link
Author

larivierec commented Mar 5, 2025

Good afternoon, @vgrassia @Thomas-Avery
i'm not sure who to mark as reviewer, but if you could direct me, or help me out I would greatly appreciate it.

We can also completely disregard the PR if it's not something you'd like to support, I thought it would be a nice addition

also, being on macos, i had to create a pack.sh I omitted it from the commits but can add it if you are interested. let me know

@larivierec
Copy link
Author

Hello.

Any updates?

@larivierec
Copy link
Author

Hello, who can help with this?

@dwbit
Copy link

dwbit commented Apr 25, 2025

Hey there, thanks for the proposal! You can also drop your contribution in the Github Discussions area here for the team/community to review: https://github.com/orgs/bitwarden/discussions/categories/secrets-manager

@larivierec larivierec force-pushed the main branch 2 times, most recently from 68c6e9f to d9d0496 Compare June 5, 2025 23:22
@larivierec
Copy link
Author

any status updates here?

- add support for parsing yaml and json structures in bitwarden secrets
- add unit tests for use cases
- update readme to reflect the new changes
- add threeflags, parse_yaml, parse_json and transform_keys to enable the feature

Signed-off-by: Christopher Larivière <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JSON Value parsing support

4 participants