Skip to content

Conversation

@ArekChr
Copy link
Collaborator

@ArekChr ArekChr commented Dec 2, 2025

Fix Android build - Update CMakeLists.txt to use correct Hermes target

Changes

  • Updated android/CMakeLists.txt to use hermes-engine::hermesvm instead of hermes-engine::libhermes

Problem

The Android build was failing with CMake error:

CMake Error at CMakeLists.txt:7 (add_library): Target "timezone-hermes-fix" links to target "hermes-engine::libhermes" but the target was not found.

@troZee troZee requested a review from Copilot December 2, 2025 11:01
Copilot finished reviewing on behalf of troZee December 2, 2025 11:02
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for React Native 0.82 by updating dependencies and fixing the Android CMake build configuration to use the correct Hermes engine target (hermes-engine::hermesvm instead of hermes-engine::libhermes).

Key Changes:

  • Fixed Android CMake configuration to use hermes-engine::hermesvm target for RN 0.82 compatibility
  • Updated React Native from 0.80.2 to 0.82.1 and React from 19.0.0 to 19.1.1
  • Modernized example app with updated build tools, Gradle wrapper, and Android configuration

Reviewed changes

Copilot reviewed 11 out of 14 changed files in this pull request and generated no comments.

Show a summary per file
File Description
android/CMakeLists.txt Fixed Hermes linking by replacing libhermes with hermesvm target
example/package.json Updated RN to 0.82.1, React to 19.1.1, and Node requirement to >=20
yarn.lock Added RN 0.82.1 dependencies and related packages
example/android/build.gradle Updated build tools to 36.0.0 and SDK versions to 36
example/android/gradle/wrapper/gradle-wrapper.properties Updated Gradle to 9.0.0
example/android/app/src/main/java/.../MainApplication.kt Modernized to use new RN 0.82 initialization API
example/ios/Podfile.lock Updated iOS dependencies for RN 0.82.1
example/ios/TimezoneHermesFixExample/Info.plist Added CADisableMinimumFrameDurationOnPhone flag

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@troZee troZee merged commit b85b1a5 into main Dec 2, 2025
5 checks passed
@troZee troZee deleted the arekchr/rn_082_support branch December 2, 2025 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants