fix: [#1928] Support details click firing the onToggle event handler #1929
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nxooah
commented
Oct 9, 2025
Nxooah
commented
- Fixed HTMLDetailsElement.dispatchEvent() to handle clicks on descendant elements of summary
- Now uses Element.closest() to find the nearest summary element in the DOM hierarchy
- Added comprehensive tests to verify the fix works for nested elements
- Resolves issue where clicking on child elements (like spans) inside summary didn't toggle details
…nt handler - Fixed HTMLDetailsElement.dispatchEvent() to handle clicks on descendant elements of summary - Now uses Element.closest() to find the nearest summary element in the DOM hierarchy - Added comprehensive tests to verify the fix works for nested elements - Resolves issue where clicking on child elements (like spans) inside summary didn't toggle details
Nxooah
force-pushed
the
fix-details-toggle-issue-1928
branch
from
b175e5d to
22f9960
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.