-
Notifications
You must be signed in to change notification settings - Fork 2k
[CHORE]: Change store_tokens to include_tokens #5959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: graphite-base/5959
Are you sure you want to change the base?
Conversation
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
Renamed store_tokens flag to include_tokens across sparse EFs This PR renames the Key Changes• Replaced Affected Areas• chromadb/utils/embedding_functions/chroma_bm25_embedding_function.py This summary was automatically generated by @propel-code-bot |
chromadb/utils/embedding_functions/chroma_bm25_embedding_function.py
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
21b4751 to
83d68e3
Compare
e87ccb6 to
0875d67
Compare
chromadb/utils/embedding_functions/chroma_cloud_splade_embedding_function.py
Outdated
Show resolved
Hide resolved
83d68e3 to
899d2c2
Compare
0875d67 to
dae1739
Compare
|
What about |
899d2c2 to
aa8a6e1
Compare
chromadb/utils/embedding_functions/chroma_cloud_splade_embedding_function.py
Show resolved
Hide resolved
0eb60a7 to
ea28e9d
Compare

Description of changes
Summarize the changes made by this PR.
Test plan
How are these changes tested?
pytestfor python,yarn testfor js,cargo testfor rustMigration plan
Are there any migrations, or any forwards/backwards compatibility changes needed in order to make sure this change deploys reliably?
Observability plan
What is the plan to instrument and monitor this change?
Documentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs section?