Skip to content

Comments #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jessX7 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Comments #10

jessX7 wants to merge 3 commits into from

Conversation

@jessX7
Copy link

@jessX7 jessX7 commented Sep 19, 2024

No description provided.

@doradohunter
Copy link

doradohunter commented Sep 19, 2024

Some things I noticed when testing your page:

  • When a user first enters the page, there are no photos showing (by default, you should display all the photos)
  • When you click one of the filters, and then click the "Load more" button, more unrelated photos get added. You should only load more photos related to that filter, and also consider hiding the Load more button if there are no more photos to show

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jessX7 @doradohunter