Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 17, 2025

Add Visual Studio 2026 support to InstallVisualStudio.ps1

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Enable VS 2026 installation via build-from-source script

Description

The InstallVisualStudio.ps1 script only supported VS 2022. This adds VS 2026 support following the existing pattern where VS 2022 maps to internal version 17.

Script changes:

  • Added '2026' to Version parameter ValidateSet
  • Map VS 2026 → internal version 18
  • Updated path prefix logic to handle version 18
  • Updated parameter documentation
  • Added logic to handle VS 2026's different channel naming convention (stable/insiders instead of release/pre)

Response files:
Created six VS 2026 JSON configuration files (vs.18.*.json) mirroring the VS 2022 structure:

  • Release, Preview, and IntPreview channels for both full editions and BuildTools
  • Channel URIs use VS 2026's naming: stable (Release), insiders (Preview), and intpreview (IntPreview)
  • Channel IDs use VisualStudio.18.{Channel} format
  • Updated Windows SDK from Windows10SDK.19041 to Windows11SDK.22621 (latest available)

No changes to existing VS 2022 functionality. Backward compatibility maintained.

Original prompt

This section details on the original issue you should resolve

<issue_title>Build from source instructions need to be updated for VS 2026</issue_title>
<issue_description>Instructions here: https://github.com/dotnet/aspnetcore/blob/main/docs/BuildFromSource.md

Specifically, the InstallVisualStudio.ps1 script needs to be updated to support 2026. It only allows VS 2022.</issue_description>

Comments on the Issue (you are @copilot in this section)


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI changed the title [WIP] Update build from source instructions for Visual Studio 2026 Add Visual Studio 2026 support to InstallVisualStudio.ps1 Nov 17, 2025
Copilot finished work on behalf of adityamandaleeka November 17, 2025 23:03
@adityamandaleeka
Copy link
Member

@copilot the internal number for VS2026 is 18, not 19.

Copy link
Contributor Author

Copilot AI commented Nov 17, 2025

@copilot the internal number for VS2026 is 18, not 19.

Corrected to version 18. Updated the version mapping in InstallVisualStudio.ps1 and renamed all JSON files from vs.19.* to vs.18.* with updated channel URIs and IDs. Commit: 9c0c236

"Microsoft.VisualStudio.Component.VC.ATL.ARM64",
"Microsoft.VisualStudio.Component.VC.Tools.ARM64",
"Microsoft.VisualStudio.Component.VC.Tools.x86.x64",
"Microsoft.VisualStudio.Component.VC.14.29.16.11.ARM64",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where did these numbers come from?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@wtgodbe wtgodbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if it works locally

@adityamandaleeka
Copy link
Member

@copilot I tried this out and had to make more changes since the channel names for VS2026 are different (https://learn.microsoft.com/en-us/visualstudio/releases/2026/release-rhythm). I also had to update the Windows SDK version since the old Win10 version we were using is no longer available.

Copy link
Contributor Author

Copilot AI commented Dec 4, 2025

@copilot I tried this out and had to make more changes since the channel names for VS2026 are different (https://learn.microsoft.com/en-us/visualstudio/releases/2026/release-rhythm). I also had to upd...

Understood. I've verified the changes - the VS 2026 channel URIs are now correctly using "stable" and "insiders" instead of "release" and "pre", and the Windows SDK has been updated to Windows11SDK.22621. The implementation looks correct based on the Microsoft documentation.

Copilot finished work on behalf of adityamandaleeka December 4, 2025 21:37
The Windows 10 SDK 19041 is not available in VS 2026. Update to
Windows 11 SDK 22621 which is available in both VS 2022 and VS 2026.

- Update Cpp.Common.props WindowsTargetPlatformVersion
- Update all vs.17.*.json and vs.18.*.json installer configs
@adityamandaleeka adityamandaleeka marked this pull request as ready for review December 5, 2025 00:52
Copilot AI review requested due to automatic review settings December 5, 2025 00:52
Copilot finished reviewing on behalf of adityamandaleeka December 5, 2025 01:05
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds Visual Studio 2026 support to the InstallVisualStudio.ps1 build script, enabling developers to install and configure VS 2026 for building ASP.NET Core from source. The implementation follows the existing VS 2022 pattern, mapping VS 2026 to internal version 18 and accommodating VS 2026's updated channel naming conventions (stable/insiders instead of release/pre).

Key changes:

  • PowerShell script updated to support VS 2026 with proper version mapping and channel URI logic
  • Six new VS 2026 JSON configuration files created for all edition/channel combinations
  • Windows SDK upgraded from 10.0.19041.0 to 10.0.22621.0 across all VS configurations
  • Removed IHttpResponse4 interface definition from C++ code (now provided by upgraded Windows SDK)

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
eng/scripts/InstallVisualStudio.ps1 Added VS 2026 parameter validation, version mapping (2026→18), channel URI logic for stable/insiders naming, and install path handling for VS 2026
eng/scripts/vs.18.json VS 2026 Release channel configuration with Windows 11 SDK 22621 and v143 toolset components
eng/scripts/vs.18.preview.json VS 2026 Preview/Insiders channel configuration
eng/scripts/vs.18.intpreview.json VS 2026 IntPreview channel configuration
eng/scripts/vs.18.buildtools.json VS 2026 BuildTools Release channel configuration with additional build-specific components
eng/scripts/vs.18.buildtools.preview.json VS 2026 BuildTools Preview/Insiders channel configuration
eng/scripts/vs.18.buildtools.intpreview.json VS 2026 BuildTools IntPreview channel configuration
eng/scripts/vs.17.json Updated Windows SDK from 10.0.19041 to 10.0.22621 for VS 2022 Release
eng/scripts/vs.17.preview.json Updated Windows SDK from 10.0.19041 to 10.0.22621 for VS 2022 Preview
eng/scripts/vs.17.intpreview.json Updated Windows SDK from 10.0.19041 to 10.0.22621 for VS 2022 IntPreview
eng/scripts/vs.17.buildtools.json Updated Windows SDK from 10.0.19041 to 10.0.22621 for VS 2022 BuildTools Release
eng/scripts/vs.17.buildtools.preview.json Updated Windows SDK from 10.0.19041 to 10.0.22621 for VS 2022 BuildTools Preview
eng/scripts/vs.17.buildtools.intpreview.json Updated Windows SDK from 10.0.19041 to 10.0.22621 for VS 2022 BuildTools IntPreview
eng/targets/Cpp.Common.props Updated WindowsTargetPlatformVersion to 10.0.22621.0 and generalized comment to reference all VS version JSON files
src/Servers/IIS/AspNetCoreModuleV2/InProcessRequestHandler/managedexports.cpp Removed local IHttpResponse4 interface definition (now provided by Windows SDK 22621)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build from source instructions need to be updated for VS 2026

4 participants