Add manage button to series blocks #1616
Conversation
This was an inline union type before that was used for both series and videos, and soon to be used for playlists. Creating a type for that just made sense (in my mind).
This button not shown in a regular realm context, but only in series blocks on single series pages. That somewhat mirrors what we do with video blocks. Putting it everywhere would clutter up the UI. On the other hand, this might not achieve the desired effect of making it easier to get to that manage page in the first place. So maybe it should actually be shown in every context, but only for people with write access.
This was getting out of hand. There is no great solution, but batching some props to later destcructure them seems ok and increases readability at least a little.
And also show that button on every block if the conditions allow (see the other commit message for reasoning). Also removes that other condition (`isSingleItemPage`) or rather the function that returns the condition. It wasn't used anyway (guess that got lost in some edit again.... gotta pay more attention when using `ctrl + z`).
|
Thanks for adding the button. I think, we/you should invest some effort in improving the display of series (especially for smaller screens). What I observed and consider suboptimal:
|
|
Thank you for testing, David. This turned out to be more tricky than expected (which is weird because it looks pretty trivial). I made another proposition in #1618, which fixes the issues that you have observed and moves the buttons to the top. I also removed the "share" and "manage" text, as these should be pretty much understandable without text. That allows some more room for title and decription. I am also still leaning towards keeping the buttons on the bottom. |
2 participants
This buttons links directly to the "series details" page. I was considering to only add it to dedicated series pages, but that kinda defeats the purpose of getting there more easily.
The button is only shown if you have write access for that series.
Also includes some refactoring of semi-related code.
To review, probably just ignore individual commits (maybe read the messages tho).
Closes #1594