feat(preprod): Add preprod images download endpoint #102117

rbro112 · 2025-10-24T23:55:42Z

Adds a new preprod /files/images/<image_id> endpoint which allows our frontend to download images from an ID with objectstore. First to be used with app icons coming soon.

Tested fully E2E locally and all works well. To work, this is reliant on landing getsentry/launchpad#430 once we get a published version of the objectstore client, but since nobody will be consuming this endpoint until we land the stacked PR (#102118) this is safe to go ahead and merge.

rbro112 · 2025-10-24T23:55:59Z

feat(preprod): Wireup app icon frontend #102118
feat(preprod): Add preprod images download endpoint #102117 👈 (View in Graphite)
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

src/sentry/preprod/api/endpoints/project_preprod_artifact_icon.py

src/sentry/preprod/api/endpoints/urls.py

src/sentry/preprod/api/endpoints/project_preprod_artifact_image.py

rbro112 · 2025-10-30T18:48:14Z

src/sentry/preprod/analytics.py

-@analytics.eventclass("preprod_artifact.api.size_analysis_download")
-class PreprodArtifactApiSizeAnalysisDownloadEvent(analytics.Event):
+@analytics.eventclass("preprod_artifact.api.get_build_details")
+class PreprodArtifactApiGetBuildDetailsEvent(analytics.Event):


I didn't change these, I just reordered a few of these to match the .register order below

src/sentry/preprod/analytics.py

src/sentry/preprod/api/endpoints/project_preprod_artifact_image.py

codecov · 2025-10-30T19:00:43Z

❌ 2 Tests Failed:

Tests completed	Failed	Passed	Skipped
29948	2	29946	251

View the top 2 failed test(s) by shortest run time

tests.sentry.preprod.api.endpoints.test_preprod_artifact_image.ProjectPreprodArtifactImageTest::test_successful_image_retrieval_heic

Stack Traces | 3.33s run time

#x1B[1m#x1B[.../api/endpoints/test_preprod_artifact_image.py#x1B[0m:81: in test_successful_image_retrieval_heic
    client.put(BytesIO(heic_data), key=f"{self.org.id}/{self.project.id}/test-image-123")
#x1B[1m#x1B[31m.venv/lib/python3.13.../site-packages/objectstore_client/client.py#x1B[0m:263: in put
    response = self._pool.request(
#x1B[1m#x1B[31m.venv/lib/python3.13....../site-packages/urllib3/_request_methods.py#x1B[0m:144: in request
    return self.request_encode_body(
#x1B[1m#x1B[31m.venv/lib/python3.13....../site-packages/urllib3/_request_methods.py#x1B[0m:279: in request_encode_body
    return self.urlopen(method, url, **extra_kw)
#x1B[1m#x1B[31m.venv/lib/python3.13....../site-packages/urllib3/connectionpool.py#x1B[0m:873: in urlopen
    return self.urlopen(
#x1B[1m#x1B[31m.venv/lib/python3.13....../site-packages/urllib3/connectionpool.py#x1B[0m:763: in urlopen
    body_pos = set_file_position(body, body_pos)
#x1B[1m#x1B[31m.venv/lib/python3.13.../urllib3/util/request.py#x1B[0m:142: in set_file_position
    rewind_body(body, pos)
#x1B[1m#x1B[31m.venv/lib/python3.13.../urllib3/util/request.py#x1B[0m:179: in rewind_body
    raise ValueError(
#x1B[1m#x1B[31mE   ValueError: body_pos must be of type integer, instead it was <class 'int'>.#x1B[0m

tests.snuba.api.endpoints.test_organization_events_stats_ourlogs.OrganizationEventsStatsOurlogsEndpointTest::test_homepage_query

Stack Traces | 14.7s run time

#x1B[1m#x1B[31mtests/conftest.py#x1B[0m:56: in unclosed_files
    assert _open_files() == fds
#x1B[1m#x1B[31mE   AssertionError: assert frozenset({'/.../cacert.pem'}) == frozenset({'/dev/null'})#x1B[0m
#x1B[1m#x1B[31mE     #x1B[0m
#x1B[1m#x1B[31mE     Extra items in the left set:#x1B[0m
#x1B[1m#x1B[31mE     '.../sentry/sentry/.venv/lib/python3.13....../site-packages/certifi/cacert.pem'#x1B[0m
#x1B[1m#x1B[31mE     #x1B[0m
#x1B[1m#x1B[31mE     Full diff:#x1B[0m
#x1B[1m#x1B[31mE       frozenset({#x1B[0m
#x1B[1m#x1B[31mE           '/dev/null',#x1B[0m
#x1B[1m#x1B[31mE     +     '.../sentry/sentry/.venv/lib/python3.13....../site-packages/certifi/cacert.pem',#x1B[0m
#x1B[1m#x1B[31mE       })#x1B[0m

To view more test analytics, go to the Test Analytics Dashboard
_{📋 Got 3 mins? Take this short survey to help us improve Test Analytics.}

noahsmartin · 2025-10-30T19:41:59Z

src/sentry/preprod/api/endpoints/project_preprod_artifact_image.py

+logger = logging.getLogger(__name__)
+
+
+def detect_image_content_type(image_data: bytes) -> str:


From Jan's comment below it sounds like eventually this can be set on write and we wouldn't have to do it here on read, but this seems ok for now to unblock testing

Yep, before merge I'll leverage a custom metadata field and we can use the first class one as soon as Jan & team land that.

There should be helpers for this in the objectstore client now: https://sentry.slack.com/archives/C08S3SK6JEN/p1763139914180699?thread_ts=1762422386.367739&cid=C08S3SK6JEN

rbro112 · 2025-11-18T22:47:32Z

src/sentry/preprod/api/models/project_preprod_build_details_models.py

    platform: Platform | None = None
    is_installable: bool
    build_configuration: str | None = None
+    app_icon_id: str | None = None


This is related to app icon, not the generic download endpoint, but should be fine to merge as the frontend does not yet use this until #102118 lands

rbro112 · 2025-11-19T02:26:42Z

src/sentry/objectstore/__init__.py

    return _ATTACHMENTS_CLIENT.session(_ATTACHMENTS_USECASE, org=org, project=project)
+
+
+def get_preprod_session(org: int, project: int) -> Session:


@jan-auer saw this practice already used for attachments, is this how you all would recommend using a global session?

Yeah. Although you might as well create a dict mapping Usecase -> Client | None to store the usecase and the client, as I can see us adding more of these over time.

cursor · 2025-11-20T21:08:13Z

src/sentry/preprod/api/endpoints/project_preprod_artifact_image.py

+                    "image_id": image_id,
+                },
+            )
+            return HttpResponse({"error": "Internal server error"}, status=500)


Bug: Invalid dictionary passed to HttpResponse without JSON serialization

The error response passes a dictionary directly to HttpResponse instead of serializing it to JSON. HttpResponse expects string or bytes content, and will convert the dict to its Python string representation (e.g., "{'error': '...'}") instead of valid JSON. Use json.dumps() to serialize the dictionary first.

cursor · 2025-11-20T21:08:13Z

src/sentry/preprod/api/endpoints/project_preprod_artifact_image.py

+                    "image_id": image_id,
+                },
+            )
+            return HttpResponse({"error": "Internal server error"}, status=500)


Bug: Invalid dictionary passed to HttpResponse without JSON serialization

The error response passes a dictionary directly to HttpResponse instead of serializing it to JSON. HttpResponse expects string or bytes content, and will convert the dict to its Python string representation (e.g., "{'error': '...'}") instead of valid JSON. Use json.dumps() to serialize the dictionary first, or use Response from rest_framework.

github-actions · 2025-11-20T21:09:27Z

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

sentry · 2025-11-25T14:28:16Z

src/sentry/preprod/api/endpoints/project_preprod_artifact_image.py

+                    "image_id": image_id,
+                },
+            )
+            return HttpResponse({"error": "Internal server error"}, status=500)


Bug: The HttpResponse constructor at line 55 receives a dictionary, which it does not handle correctly, leading to a TypeError or malformed response.
_{Severity: HIGH | Confidence: High}

🔍 Detailed Analysis

The HttpResponse constructor at line 55 is called with a Python dictionary {'error': 'Internal server error'} as its first argument. Django's HttpResponse expects content to be bytes or a string, not a dictionary. This will cause a TypeError when an exception occurs in the try block (line 39), preventing a graceful 500 error response and instead crashing the server.

💡 Suggested Fix

Serialize the dictionary to JSON: HttpResponse(json.dumps({'error': 'Internal server error'}), content_type='application/json', status=500) or return plain text: HttpResponse('Internal server error', status=500).

🤖 Prompt for AI Agent

Review the code at the location below. A potential bug has been identified by an AI agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not valid. Location: src/sentry/preprod/api/endpoints/project_preprod_artifact_image.py#L55 Potential issue: The `HttpResponse` constructor at line 55 is called with a Python dictionary `{'error': 'Internal server error'}` as its first argument. Django's `HttpResponse` expects content to be bytes or a string, not a dictionary. This will cause a `TypeError` when an exception occurs in the `try` block (line 39), preventing a graceful 500 error response and instead crashing the server.

_{Did we get this right? 👍 / 👎 to inform future reviews.}
_{Reference ID: 3502411}

rbro112 mentioned this pull request Oct 24, 2025

feat(preprod): Wireup app icon frontend #102118

Draft

github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Oct 24, 2025

vercel bot deployed to Preview October 24, 2025 23:57 View deployment

jasonyuezhang mentioned this pull request Oct 25, 2025

Add Preprod endpoint to download project app icons jasonyuezhang/sentry#91

Open

rbro112 commented Oct 28, 2025

View reviewed changes

src/sentry/preprod/api/endpoints/project_preprod_artifact_icon.py Outdated Show resolved Hide resolved

vercel bot deployed to Preview October 28, 2025 18:35 View deployment

rbro112 changed the title ~~Add app-icon download endpoint~~ feat(preprod): Add app-icon download endpoint Oct 28, 2025

rbro112 marked this pull request as ready for review October 28, 2025 19:35

rbro112 requested a review from a team as a code owner October 28, 2025 19:35

sentry bot reviewed Oct 28, 2025

View reviewed changes

src/sentry/preprod/api/endpoints/urls.py Outdated Show resolved Hide resolved

src/sentry/preprod/api/endpoints/project_preprod_artifact_image.py Outdated Show resolved Hide resolved

rbro112 changed the title ~~feat(preprod): Add app-icon download endpoint~~ feat(preprod): Add preprod images download endpoint Oct 30, 2025

vercel bot deployed to Preview October 30, 2025 18:19 View deployment

rbro112 force-pushed the ryan/add_api_to_serve_preprod_app_icons branch from c5561d3 to 6835a33 Compare October 30, 2025 18:28

vercel bot deployed to Preview October 30, 2025 18:30 View deployment

vercel bot deployed to Preview October 30, 2025 18:40 View deployment

vercel bot deployed to Preview October 30, 2025 18:44 View deployment

rbro112 commented Oct 30, 2025

View reviewed changes

src/sentry/preprod/analytics.py Outdated Show resolved Hide resolved

trevor-e approved these changes Oct 30, 2025

View reviewed changes

vercel bot deployed to Preview October 30, 2025 19:06 View deployment

noahsmartin reviewed Oct 30, 2025

View reviewed changes

rbro112 force-pushed the ryan/add_api_to_serve_preprod_app_icons branch from 35dbef3 to 36eeea1 Compare November 12, 2025 19:41

vercel bot deployed to Preview November 12, 2025 19:43 View deployment

rbro112 commented Nov 18, 2025

View reviewed changes

rbro112 force-pushed the ryan/add_api_to_serve_preprod_app_icons branch from 36eeea1 to 4f0e1e9 Compare November 19, 2025 02:23

vercel bot deployed to Preview November 19, 2025 02:25 View deployment

rbro112 commented Nov 19, 2025

View reviewed changes

Add app-icon download endpoint

4f1cdd7

noahsmartin and others added 7 commits November 20, 2025 15:59

Make endpoint work for snapshots too

959819a

Updates

f0d545a

HttpResponse

ad89232

Feedback

9b7255f

Request

d1bceb6

Update to latest practices

473549f

remove client error

24d9e1d

noahsmartin force-pushed the ryan/add_api_to_serve_preprod_app_icons branch from 4f0e1e9 to 24d9e1d Compare November 20, 2025 21:05

cursor bot reviewed Nov 20, 2025

View reviewed changes

vercel bot deployed to Preview November 20, 2025 21:08 View deployment

github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Nov 20, 2025

vercel bot deployed to Preview November 20, 2025 21:12 View deployment

noahsmartin force-pushed the ryan/add_api_to_serve_preprod_app_icons branch from 7d51dc7 to 370b825 Compare November 21, 2025 15:20

noahsmartin requested a review from a team as a code owner November 21, 2025 15:20

vercel bot deployed to Preview November 21, 2025 15:25 View deployment

Update tests

25db450

noahsmartin force-pushed the ryan/add_api_to_serve_preprod_app_icons branch from 7aedd97 to 25db450 Compare November 21, 2025 16:42

vercel bot deployed to Preview November 21, 2025 16:47 View deployment

fix tests

f7a9713

noahsmartin force-pushed the ryan/add_api_to_serve_preprod_app_icons branch from 5d540ea to f7a9713 Compare November 25, 2025 14:23

🛠️ Sync API Urls to TypeScirpt

e2a8a0c

sentry bot reviewed Nov 25, 2025

View reviewed changes

vercel bot deployed to Preview November 25, 2025 14:29 View deployment

		logger = logging.getLogger(__name__)


		def detect_image_content_type(image_data: bytes) -> str:

		return _ATTACHMENTS_CLIENT.session(_ATTACHMENTS_USECASE, org=org, project=project)


		def get_preprod_session(org: int, project: int) -> Session:

Uh oh!

feat(preprod): Add preprod images download endpoint #102117

Are you sure you want to change the base?

feat(preprod): Add preprod images download endpoint #102117

Uh oh!

Conversation

rbro112 commented Oct 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rbro112 commented Oct 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rbro112 Oct 30, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Oct 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ 2 Tests Failed:

Uh oh!

noahsmartin Oct 30, 2025

Choose a reason for hiding this comment

Uh oh!

rbro112 Oct 30, 2025

Choose a reason for hiding this comment

Uh oh!

rbro112 Nov 18, 2025

Choose a reason for hiding this comment

Uh oh!

rbro112 Nov 18, 2025

Choose a reason for hiding this comment

Uh oh!

rbro112 Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

lcian Nov 22, 2025

Choose a reason for hiding this comment

Uh oh!

cursor bot Nov 20, 2025

Choose a reason for hiding this comment

Bug: Invalid dictionary passed to HttpResponse without JSON serialization

Uh oh!

cursor bot Nov 20, 2025

Choose a reason for hiding this comment

Bug: Invalid dictionary passed to HttpResponse without JSON serialization

Uh oh!

github-actions bot commented Nov 20, 2025

Uh oh!

sentry bot Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

rbro112 commented Oct 24, 2025 •

edited

Loading

rbro112 commented Oct 24, 2025 •

edited

Loading

codecov bot commented Oct 30, 2025 •

edited

Loading