ci: lightweight dockerfile using bookworm-slim #413
Conversation
Dockerfile.dev
Outdated
| @@ -0,0 +1,55 @@ | |||
| # Build image | |||
There was a problem hiding this comment.
Honestly I don't know. I was gonna ask you about that: why are you using rust as your base image?
There was a problem hiding this comment.
If you don't have any importance/relying on rust being the base image, we can delete this
There was a problem hiding this comment.
No I mean, why did you create this new file?
There was a problem hiding this comment.
Oh, so that you can still use it if you depends on rust being base image.
There was a problem hiding this comment.
Where would it be used? The images we use in self-hosted, and saas all come from the standard Dockerfile. Could we remove this dockerfile as it won't be used?
|
/gcbrun |
markstory
left a comment
markstory
left a comment
There was a problem hiding this comment.
This looks good once we get the Dockerfile.dev removed.
|
@markstory done! |
|
/gcbrun |
|
PR reverted: 44e3d1d |
This reverts commit cca2061. Co-authored-by: markstory <[email protected]>
|
This had to be reverted as the runtime image had broken SSL |
3 participants
The runtime image shouldn't use
rustas the image base, since we don't need anycargoorrustcbinary. Instead, we can just usebookworm-slimand install sqlite3 dev headers there.