-
Notifications
You must be signed in to change notification settings - Fork 123
Speed up BBS e2e tests by reducing repo migrations #1470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Unit Test Results 1 files 1 suites 10m 24s ⏱️ Results for commit 9b466e8. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR splits the BBS integration tests into separate test classes for better parallelization. However, the code contains multiple critical compilation errors that must be fixed before merging:
- All 5 new test files use a non-existent
TestHelperconstructor - All files use incorrect
ArchiveUploaderconstructor parameters - All files pass an extra
DateTimeProviderparameter toBbsClientconstructor - All files use the wrong environment variable key (
GHEC_PATinstead ofGH_PAT)
Key Changes
- Splits monolithic
BbsToGithub.cstests into 5 specialized test classes - Each test class focuses on a specific configuration (Azure Linux/Windows, AWS Linux, GitHub Storage, Multipart Upload)
- Updates GitHub Actions workflow to run tests in parallel across different runners
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 20 comments.
Show a summary per file
| File | Description |
|---|---|
BbsGithubStorageToGithub.cs |
Tests BBS migration using GitHub-hosted storage (SSH download from Linux BBS) - Contains critical bugs |
BbsGithubMultipartToGithub.cs |
Tests BBS migration with multipart upload functionality using GitHub storage - Contains critical bugs |
BbsAzureWindowsToGithub.cs |
Tests BBS migration from Windows BBS server using Azure Storage (SMB download) - Contains critical bugs |
BbsAzureLinuxToGithub.cs |
Tests BBS migration from Linux BBS server using Azure Storage (SSH download) - Contains critical bugs |
BbsAwsLinuxToGithub.cs |
Tests BBS migration from Linux BBS server using AWS S3 storage (SSH download) - Contains critical bugs |
.github/workflows/integration-tests.yml |
Updates workflow matrix to split BBS tests across different runners for parallelization |
src/OctoshiftCLI.IntegrationTests/BbsGithubMultipartToGithub.cs
Outdated
Show resolved
Hide resolved
This reverts commit 0b7f4c5.
jeviet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
Validated required/frequency
…com/github/gh-gei into brianaj/1387-speed-up-bbs-e2e-tests
ThirdPartyNotices.txt(if applicable)Fixes #1387
Changes
Modified BBS integration tests to migrate only 1 repository per test instead of 2, reducing the total number of repo migrations from 9 to 5 per test run.
Impact
The second migration was just extra verification that added ~20 minutes to CI build time without providing additional value.
Workflow ran from branch: https://github.com/github/gh-gei/actions/runs/19976506945