Skip to content

Conversation

@brianaj
Copy link
Collaborator

@brianaj brianaj commented Dec 5, 2025

  • Did you write/update appropriate tests
  • Release notes updated (if appropriate)
  • Appropriate logging output
  • Issue linked
  • Docs updated (or issue created)
  • New package licenses are added to ThirdPartyNotices.txt (if applicable)

Fixes #1387

Changes

Modified BBS integration tests to migrate only 1 repository per test instead of 2, reducing the total number of repo migrations from 9 to 5 per test run.

Impact

  • Reduces BBS e2e test runtime from ~45 min to ~30 min
  • Each BBS test scenario (Azure Storage, AWS S3, GitHub Storage, etc.) now validates with a single successful migration instead of redundant double verification
  • No loss in test coverage - one successful migration per scenario is sufficient to validate the migration path works correctly

The second migration was just extra verification that added ~20 minutes to CI build time without providing additional value.

Workflow ran from branch: https://github.com/github/gh-gei/actions/runs/19976506945

Copilot AI review requested due to automatic review settings December 5, 2025 18:47
@github-actions
Copy link

github-actions bot commented Dec 5, 2025

Unit Test Results

  1 files    1 suites   10m 24s ⏱️
960 tests 960 ✅ 0 💤 0 ❌
961 runs  961 ✅ 0 💤 0 ❌

Results for commit 9b466e8.

♻️ This comment has been updated with latest results.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR splits the BBS integration tests into separate test classes for better parallelization. However, the code contains multiple critical compilation errors that must be fixed before merging:

  1. All 5 new test files use a non-existent TestHelper constructor
  2. All files use incorrect ArchiveUploader constructor parameters
  3. All files pass an extra DateTimeProvider parameter to BbsClient constructor
  4. All files use the wrong environment variable key (GHEC_PAT instead of GH_PAT)

Key Changes

  • Splits monolithic BbsToGithub.cs tests into 5 specialized test classes
  • Each test class focuses on a specific configuration (Azure Linux/Windows, AWS Linux, GitHub Storage, Multipart Upload)
  • Updates GitHub Actions workflow to run tests in parallel across different runners

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 20 comments.

Show a summary per file
File Description
BbsGithubStorageToGithub.cs Tests BBS migration using GitHub-hosted storage (SSH download from Linux BBS) - Contains critical bugs
BbsGithubMultipartToGithub.cs Tests BBS migration with multipart upload functionality using GitHub storage - Contains critical bugs
BbsAzureWindowsToGithub.cs Tests BBS migration from Windows BBS server using Azure Storage (SMB download) - Contains critical bugs
BbsAzureLinuxToGithub.cs Tests BBS migration from Linux BBS server using Azure Storage (SSH download) - Contains critical bugs
BbsAwsLinuxToGithub.cs Tests BBS migration from Linux BBS server using AWS S3 storage (SSH download) - Contains critical bugs
.github/workflows/integration-tests.yml Updates workflow matrix to split BBS tests across different runners for parallelization

@brianaj brianaj changed the title split up bbs e2e tests Speed up BBS e2e tests by reducing repo migrations Dec 5, 2025
Copy link
Collaborator

@jeviet jeviet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved
Validated required/frequency

@brianaj brianaj enabled auto-merge December 5, 2025 22:25
@github-actions
Copy link

github-actions bot commented Dec 5, 2025

Code Coverage

Package Line Rate Branch Rate Complexity Health
ado2gh 72% 70% 712
Octoshift 83% 72% 1739
bbs2gh 83% 78% 663
gei 81% 72% 574
Summary 81% (7738 / 9604) 73% (1840 / 2521) 3688

@brianaj brianaj merged commit 37a0a4d into main Dec 5, 2025
33 of 34 checks passed
@brianaj brianaj deleted the brianaj/1387-speed-up-bbs-e2e-tests branch December 5, 2025 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Speed up BBS e2e tests in CI

4 participants