Fail loading an ACL config if the provided file is empty and enforceT… #176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ableACLConfig is true (vitessio#17274) Signed-off-by: garfthoffman <[email protected]> Signed-off-by: Mohamed Hamza <[email protected]> Co-authored-by: Mohamed Hamza <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR adds validation to fail ACL config loading when the provided file is empty and enforceTableACLConfig is true. It's a backport of a change from the main branch to ensure proper error handling for empty ACL configuration files.
- Adds validation to reject empty ACL configuration files
- Includes test coverage for the new empty file validation behavior
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| go/vt/tableacl/tableacl.go | Adds empty file validation in the init method to return an error when config file is empty |
| go/vt/tableacl/tableacl_test.go | Adds test case to verify error handling for empty ACL config files |
Signed-off-by: Mohamed Hamza <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ableACLConfig is true (vitessio#17274)
This is a backport of vitessio#17274
Description
Related Issue(s)
Checklist
Deployment Notes