Replace the pool when reopening. #181
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR implements a connection pool reopening mechanism by storing configuration and stats exporter references, allowing pools to be replaced when closed and reopened. This is a backport of a previous fix aimed at properly handling pool lifecycle management.
- Stores pool configuration and stats exporter references for later reuse
- Replaces the underlying connection pool when closing to enable clean reopening
- Introduces proper pool state management with atomic operations
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| go/vt/vttablet/tabletserver/connpool/pool.go | Stores config and stats exporter, replaces ConnPool on close |
| go/vt/dbconnpool/connection_pool.go | Adds config storage and Close method that replaces the pool |
| go/pools/smartconnpool/pool_test.go | Adds test for connection reopening behavior |
| go/pools/smartconnpool/pool.go | Implements pool state management and separate StatsExporter |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
mhamza15
force-pushed
the
mhamza/backport-18530-v19
branch
2 times, most recently
from
431ad94 to
fd4ed7b
Compare
Signed-off-by: Arthur Schreiber <[email protected]>
Signed-off-by: Arthur Schreiber <[email protected]>
Signed-off-by: Mohamed Hamza <[email protected]>
When closing the pool, there is a race condition between the closing of the `close` channel in `CloseWithContext`, and the `maybeStarving` worker closing it. We'll remove the close in `CloseWithContext` and allow the worker to close it on its next run. Signed-off-by: Mohamed Hamza <[email protected]>
Signed-off-by: Mohamed Hamza <[email protected]>
closing and normal operations Signed-off-by: Mohamed Hamza <[email protected]>
Signed-off-by: Mohamed Hamza <[email protected]>
Signed-off-by: Mohamed Hamza <[email protected]>
Signed-off-by: Mohamed Hamza <[email protected]>
mhamza15
force-pushed
the
mhamza/backport-18530-v19
branch
from
fd4ed7b to
32f06d3
Compare
mhamza15
force-pushed
the
mhamza/backport-18530-v19
branch
from
d27a57e to
bed0c14
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a backport of vitessio#18530
Related Issue(s)
Checklist
Deployment Notes