Skip to content

Conversation

@mhamza15
Copy link

Description

This is a backport of vitessio#16574

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

@mhamza15 mhamza15 self-assigned this Aug 20, 2025
Copilot AI review requested due to automatic review settings August 20, 2025 15:21
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for the innodb_lock_wait_timeout system variable by moving it from the read-only variables list to the settable variables list, enabling it to be modified at the session level.

  • Moves innodb_lock_wait_timeout from read-only to settable system variables
  • Updates AST rewriting to exclude global scope variables from rewriting
  • Adds comprehensive test coverage for both session and global variable behavior

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
go/vt/sysvars/sysvars.go Moves innodb_lock_wait_timeout from read-only to settable variables list
go/vt/sqlparser/ast_rewriting.go Updates variable rewriting logic to exclude global scope variables
go/vt/vtgate/executor_set_test.go Adds unit tests for setting innodb_lock_wait_timeout
go/vt/vtgate/executor_select_test.go Adds comprehensive test for global vs session variable behavior
go/test/endtoend/vtgate/reservedconn/sysvar_test.go Adds end-to-end test for innodb_lock_wait_timeout functionality

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

@mhamza15 mhamza15 merged commit 3fbc986 into release-20.0-github Sep 2, 2025
175 of 201 checks passed
@mhamza15 mhamza15 deleted the mhamza/backport-16574-v20 branch September 2, 2025 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants