Skip to content

Conversation

@mhamza15
Copy link

…ig (vitessio#17984)

This is a backport of vitessio#17984

Description

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

@mhamza15 mhamza15 self-assigned this Aug 22, 2025
Copilot AI review requested due to automatic review settings August 22, 2025 14:09
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enables the use of database credentials from a credentials file when verifying unmanaged tablet configurations. It backports functionality that allows tablets to fall back to credential files when passwords are not explicitly provided in configuration.

  • Modified the unmanaged tablet configuration verification to check for credentials via GetCredentialsServer() when password is empty
  • Added a test utility function to set credential file paths for testing purposes
  • Added test coverage for the new credential fallback functionality

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
go/vt/vttablet/tabletserver/tabletenv/config.go Updated verification logic to fetch passwords from credentials server when not provided
go/vt/dbconfigs/credentials.go Added test utility function to set credential file path
go/vt/vttablet/tabletserver/tabletenv/config_test.go Added test case for credential file fallback behavior
go/vt/vttablet/tabletserver/tabletenv/data/db_credentials.json Added test credential file with sample user/password

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@mhamza15 mhamza15 merged commit 383b39a into release-20.0-github Aug 22, 2025
179 of 186 checks passed
@mhamza15 mhamza15 deleted the mhamza/backport-17984-v20 branch August 22, 2025 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants