Skip to content

Conversation

@mhamza15
Copy link

@mhamza15 mhamza15 commented Sep 3, 2025

Description

This is a backport of vitessio#18369

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

Copilot AI review requested due to automatic review settings September 3, 2025 13:32
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request ensures that parsed comments are properly preserved when merging subqueries with outer queries in the Vitess query planner. The change specifically sets the comments from the outer Route operator to the merged operator when subqueries are merged.

  • Preserves SQL comments during subquery merging operations
  • Adds test coverage for comment handling in various subquery scenarios

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
go/vt/vtgate/planbuilder/operators/subquery_planning.go Adds logic to preserve comments from outer Route when merging subqueries
go/vt/vtgate/planbuilder/testdata/select_cases.json Adds test cases to verify comment preservation in subquery scenarios

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

* fix actions

Signed-off-by: Mohamed Hamza <[email protected]>

* fix actions

---------

Signed-off-by: Mohamed Hamza <[email protected]>
@github-actions
Copy link

github-actions bot commented Oct 4, 2025

This PR is being marked as stale because it has been open for 30 days with no activity. To rectify, you may do any of the following:

  • Push additional commits to the associated branch.
  • Remove the stale label.
  • Add a comment indicating why it is not stale.

If no action is taken within 7 days, this PR will be closed.

@github-actions github-actions bot added the Stale label Oct 4, 2025
@github-actions
Copy link

This PR was closed because it has been stale for 7 days with no activity.

@github-actions github-actions bot closed this Oct 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants