feat(api): retrieve app deployments based on last used data #7377

adambenhassen · 2025-12-05T10:34:25Z

Description

Adds activeAppDeployments GraphQL query to find app deployments based on usage criteria, enabling teams to identify and clean up stale deployments

Filter options:

lastUsedBefore - find deployments used but not recently
neverUsedAndCreatedBefore - find old unused deployments
name - filter by app name (partial match)

Closes CONSOLE-1504

gemini-code-assist · 2025-12-05T10:34:41Z

Summary of Changes

Hello @adambenhassen, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a significant enhancement to the API by providing a new GraphQL query, activeAppDeployments, designed to help teams efficiently identify and manage stale application deployments. This feature allows users to filter deployments based on their last usage date or creation date if they've never been used, facilitating cleanup and resource optimization. The addition of a createdAt field to the AppDeployment type further enriches the data available for these operations, ensuring better visibility into deployment lifecycle.

Highlights

New GraphQL Query: Introduced activeAppDeployments GraphQL query to retrieve app deployments based on usage and creation criteria.
Filter Options: Added filter options including lastUsedBefore (for recently unused deployments), neverUsedAndCreatedBefore (for old, never-used deployments), and name (for partial name matching). Date filters use OR logic, while the name filter uses AND logic.
AppDeployment Type Enhancement: The AppDeployment GraphQL type now includes a createdAt field to track the deployment's creation timestamp.
Comprehensive Testing: Extensive integration tests have been added to validate the functionality of the new activeAppDeployments query, covering various filter combinations and pagination.
Documentation Update: New documentation has been added to guide users on 'Finding Stale App Deployments', including usage tracking, GraphQL API querying examples, and automated cleanup workflows.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

github-actions · 2025-12-05T10:36:06Z

🚀 Snapshot Release (`alpha`)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package	Version	Info
`hive`	`8.13.0-alpha-20251205131858-16aea1d6a6e847a02f2178e50e89b4eb027bb17c`	npm ↗︎ unpkg ↗︎

github-actions · 2025-12-05T10:36:24Z

📚 Storybook Deployment

The latest changes are available as preview in: https://pr-7377.hive-storybook.pages.dev

gemini-code-assist

Code Review

This pull request introduces a new activeAppDeployments GraphQL query to find stale deployments, which is a valuable addition for maintenance and cleanup. The implementation is accompanied by thorough integration tests and clear documentation. My main feedback is a performance concern regarding how deployments are fetched and filtered, which could be problematic for targets with a large number of deployments. I've also noted an opportunity to reduce code duplication in the new tests.

packages/services/api/src/modules/app-deployments/providers/app-deployments.ts

integration-tests/tests/api/app-deployments.spec.ts

github-actions · 2025-12-05T10:40:31Z

💻 Website Preview

The latest changes are available as preview in: https://pr-7377.hive-landing-page.pages.dev

github-actions · 2025-12-05T10:41:36Z

🐋 This PR was built and pushed to the following Docker images:

Targets: build

Platforms: linux/amd64

Image Tag: 16aea1d6a6e847a02f2178e50e89b4eb027bb17c

jdolle

Great job adding descriptions, comments, and docs. These are all very helpful. I'm excited for App Deployments to get more flushed out

jdolle · 2025-12-05T17:38:11Z

packages/services/api/src/modules/app-deployments/providers/app-deployments.ts

+      paginatedDeployments = filteredDeployments.filter(deployment => {
+        const deploymentCreatedAt = new Date(deployment.createdAt).getTime();
+        return (
+          deploymentCreatedAt < cursorCreatedAt ||


I think it'd be simpler to build this into the sql query.

The date filtering happens after the postgres query (using clickhouse data) so we can't paginate in sql without potentially skipping rows that would pass the filter

jdolle · 2025-12-05T17:45:10Z

packages/services/api/src/modules/app-deployments/providers/app-deployments.ts

+          AND "retired_at" IS NULL
+          ${args.filter.name ? sql`AND "name" ILIKE ${'%' + args.filter.name + '%'}` : sql``}
+        ORDER BY "created_at" DESC, "id"
+        LIMIT ${maxDeployments}


To avoid setting this limit and to simplify this logic, I wonder if we should be flip the query order. So that you first collect, from Clickhouse, a set of the deployments that match the lastUsed filter, and then use those IDs to fetch the rest of the details from postgres. This should eliminate the overfetching and avoid any limit issues for incredibly large deployment sets

Flipping the order would severely complicate the logic, including table joins across clickhouse, which is an expensive task without the data from postgres. I do not think this is worth it, nor do I think there would be 1000 deployments(?), especially considering that the idea is to tidy old deployments

n1ru4l · 2025-12-08T11:58:49Z

packages/web/docs/src/content/schema-registry/app-deployments.mdx

This is best a follow up pr, as docs are deployed as time of merging the PR, before the code changes are deployed to production!

n1ru4l · 2025-12-08T11:59:38Z

packages/services/api/src/modules/app-deployments/module.graphql.ts

+    activeAppDeployments(
+      first: Int
+      after: String
+      filter: ActiveAppDeploymentsFilter!
+    ): AppDeploymentConnection!


The corresponding types need to be annotated with @tag(name:"public"), so they are part of the public GraphQL API.

n1ru4l

See https://github.com/graphql-hive/console/pull/7377/files/16aea1d6a6e847a02f2178e50e89b4eb027bb17c#r2598351349 and https://github.com/graphql-hive/console/pull/7377/files/16aea1d6a6e847a02f2178e50e89b4eb027bb17c#r2598348711

Aside from that, the logic seems legit for, given the technical constraints of having to query two databases. If there is general thoughts on how we could improve this set up, lets start a discussion about it independently.

github-actions bot deployed to preview December 5, 2025 10:36 View deployment

gemini-code-assist bot reviewed Dec 5, 2025

View reviewed changes

packages/services/api/src/modules/app-deployments/providers/app-deployments.ts Show resolved Hide resolved

integration-tests/tests/api/app-deployments.spec.ts Show resolved Hide resolved

github-actions bot deployed to preview December 5, 2025 10:40 View deployment

adambenhassen marked this pull request as draft December 5, 2025 10:47

adambenhassen changed the title ~~feat(api): retrieve app deployments based on last used data~~ WIP feat(api): retrieve app deployments based on last used data Dec 5, 2025

github-actions bot deployed to preview December 5, 2025 10:49 View deployment

github-actions bot deployed to preview December 5, 2025 10:52 View deployment

github-actions bot deployed to preview December 5, 2025 10:56 View deployment

github-actions bot deployed to preview December 5, 2025 10:59 View deployment

github-actions bot deployed to preview December 5, 2025 11:03 View deployment

github-actions bot deployed to preview December 5, 2025 11:14 View deployment

github-actions bot deployed to preview December 5, 2025 11:19 View deployment

github-actions bot deployed to preview December 5, 2025 11:21 View deployment

github-actions bot deployed to preview December 5, 2025 11:26 View deployment

github-actions bot deployed to preview December 5, 2025 11:32 View deployment

adambenhassen marked this pull request as ready for review December 5, 2025 11:35

github-actions bot deployed to preview December 5, 2025 11:36 View deployment

adambenhassen changed the title ~~WIP feat(api): retrieve app deployments based on last used data~~ feat(api): retrieve app deployments based on last used data Dec 5, 2025

adambenhassen added 7 commits December 5, 2025 15:17

feat(api): retrieve app deployments based on last used data

e02a9ed

return all active deployments when no filter is provided

faaf053

throw error when cursor or chsql/psql query fails

9861290

test for invalid date filter

3d0aaab

fix cursor, hard limit to 1000 rows per query

f0f1c88

validate filter dates (defensive code)

7fa54ce

test name+lastUserBefore

4ebb342

test pagination clamp, reach higher code coverage

16aea1d

adambenhassen force-pushed the adam/console-1504 branch from 7af3899 to 16aea1d Compare December 5, 2025 13:17

github-actions bot deployed to preview December 5, 2025 13:19 View deployment

github-actions bot deployed to preview December 5, 2025 13:24 View deployment

jdolle reviewed Dec 5, 2025

View reviewed changes

adambenhassen requested a review from n1ru4l December 8, 2025 11:26

n1ru4l reviewed Dec 8, 2025

View reviewed changes

n1ru4l requested changes Dec 8, 2025

View reviewed changes

feat(api): retrieve app deployments based on last used data #7377

Are you sure you want to change the base?

feat(api): retrieve app deployments based on last used data #7377

Uh oh!

Conversation

adambenhassen commented Dec 5, 2025

Description

Filter options:

Uh oh!

gemini-code-assist bot commented Dec 5, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

github-actions bot commented Dec 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🚀 Snapshot Release (alpha)

Uh oh!

github-actions bot commented Dec 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📚 Storybook Deployment

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Dec 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💻 Website Preview

Uh oh!

github-actions bot commented Dec 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jdolle left a comment

Choose a reason for hiding this comment

Uh oh!

jdolle Dec 5, 2025

Choose a reason for hiding this comment

Uh oh!

adambenhassen Dec 8, 2025

Choose a reason for hiding this comment

Uh oh!

jdolle Dec 5, 2025

Choose a reason for hiding this comment

Uh oh!

adambenhassen Dec 8, 2025

Choose a reason for hiding this comment

Uh oh!

n1ru4l Dec 8, 2025

Choose a reason for hiding this comment

Uh oh!

n1ru4l Dec 8, 2025

Choose a reason for hiding this comment

Uh oh!

n1ru4l left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

github-actions bot commented Dec 5, 2025 •

edited

Loading

🚀 Snapshot Release (`alpha`)

github-actions bot commented Dec 5, 2025 •

edited

Loading

github-actions bot commented Dec 5, 2025 •

edited

Loading

github-actions bot commented Dec 5, 2025 •

edited

Loading

n1ru4l left a comment •

edited

Loading